Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure as composite action with matrix config #43

Open
cansavvy opened this issue Jan 8, 2025 · 0 comments
Open

Restructure as composite action with matrix config #43

cansavvy opened this issue Jan 8, 2025 · 0 comments

Comments

@cansavvy
Copy link
Contributor

cansavvy commented Jan 8, 2025

I think really we want report-maker.yml action to be a composite action and that's how this needs to be restructured.

Instead of running each we should probably have it like:

  run-check:
    name: Test - ${{ matrix.config.test_name }}
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
      matrix:
        config:
          - {test_name: "spell_check",   report_path: "check_reports/spell_check_results.tsv", toggle: $inputs.SPELL_TOGGLE}
          - {test_name: "url_check",   report_path: "check_reports/url_check_results.tsv", 
          - toggle: $inputs.URL_TOGGLE}
          - {test_name: "quiz_check",   report_path: "check_reports/quiz_check_results.tsv", toggle: $inputs.CHECK_TOGGLE}

Where inputs would be a toggle that would turn the action on or off.

A big question mark with this approach though is that output in matrix configs like this does get overwritten. But because we save our reports to files this might be okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant