Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomEvent does not change color when light/dark mode changed #1003

Open
1 task done
jyang0403 opened this issue Apr 22, 2023 · 1 comment
Open
1 task done

CustomEvent does not change color when light/dark mode changed #1003

jyang0403 opened this issue Apr 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jyang0403
Copy link

Contact Details

No response

Describe the Bug

As above, Jacky mentioned that the color is hardcoded.

How can we reproduce the problem?

Steps to reproduce the behavior:

  1. Create a custom event
  2. Change the color from light/dark to the opposite

Expected Behavior

Should alternate between lighter/darker shades of grey, but they remain the same.

OS Version

Windows

Which browsers are you seeing the problem on?

Chrome

Additional Information

No response

Code of Conduct

  • I agree to follow Semester.ly's Code of Conduct
@jyang0403 jyang0403 added the bug Something isn't working label Apr 22, 2023
@JJamesWWang
Copy link
Member

This isn't necessarily a bug because the colors are saved when they are created. A "fix" may be to change the colors if they're the same as the default colors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JJamesWWang @jyang0403