Importing from esm in Node.js is broken in v2.1.0 #80

alanshaw · 2021-05-20T08:25:47Z

Importing from esm in Node.js is broken in v2.1.0:

import { RateLimiter } from 'limiter'
         ^^^^^^^^^^^
SyntaxError: Named export 'RateLimiter' not found. The requested module 'limiter' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'limiter';
const { RateLimiter } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:105:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:151:5)
    at async Loader.import (node:internal/modules/esm/loader:166:24)
    at async Object.loadESM (node:internal/process/esm_loader:68:5)

v2.0.1 was working.

jhurliman/node-rate-limiter#80

olizilla · 2021-07-21T20:33:29Z

Fails for me too on node v16.4.2. Pinning [email protected] works.

michael-land · 2021-08-28T03:35:23Z

experiencing the same in 2.1.0

LandonSchropp · 2021-10-21T20:33:47Z

Same here.

Mwni · 2021-11-01T23:42:13Z

Same

raxod502 · 2021-12-22T21:41:57Z

Same here---I had some trouble finding this thread, so here is another possible error message you can get, for the benefit of other Googlers:

(node:290874) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/home/raxod502/files/temp/limiter-bug/node_modules/limiter/dist/esm/index.js:1
export * from "./RateLimiter.js";
^^^^^^

SyntaxError: Unexpected token 'export'
    at Object.compileFunction (node:vm:355:18)
    at wrapSafe (node:internal/modules/cjs/loader:1022:15)
    at Module._compile (node:internal/modules/cjs/loader:1056:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
    at Module.load (node:internal/modules/cjs/loader:972:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:201:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:154:23)
    at async Loader.import (node:internal/modules/esm/loader:177:24)
    at async Object.loadESM (node:internal/process/esm_loader:68:5)

- Upgrade eslint - Lock limiter to 2.0.1 (jhurliman/node-rate-limiter#80)

nigelis · 2022-01-12T05:59:47Z

Same

w0rldart · 2022-01-17T15:39:35Z

Fails on v14.18.3 too

cornopaez · 2022-01-28T00:11:07Z

Same issue here. Having issues with node 16.13.2. As with others previously mentioned, pinning limiter to 2.0.1 works great.

yarfuo · 2022-02-22T10:47:36Z

Hello!

I struggling with the same error. I would be happy to help, but I'm not proficient in Node.js.

Thanks :)

sudiptosarkar · 2022-08-02T10:22:52Z

@jhurliman, Can we please merge just-performance#4 and #92?

Those two PRs will fix this issue (I'm trying to use this in my framework, and need this fix to be able to use it. 🙃).

kutsan · 2022-08-06T11:46:18Z

Friendly ping @jhurliman.

brandonros · 2023-03-28T02:18:47Z

friendly ping @jhurliman

sudiptosarkar · 2023-03-29T07:38:11Z

For anyone still waiting, limiter-es6-compat

alanshaw · 2023-04-25T09:11:04Z

@sudiptosarkar thanks 🙏

shuklaalok7 · 2023-04-26T16:58:08Z

@sudiptosarkar I am getting this error. May you please help with this?
My import is,

import {RateLimiter} from "limiter-es6-compat"

sudiptosarkar · 2023-05-12T03:07:19Z

@shuklaalok7, Can you please do the following?

make a barebones repo replicating the issue?
raise the issue in the compat repository: https://github.com/sudiptosarkar/node-rate-limiter

Also, does it have the same problem with limiter when running with typescript?

wayne5540 · 2023-06-06T05:25:07Z

For those who are still blocked, you can try following code to use require instead of import.

import { createRequire } from "module";
const require = createRequire(import.meta.url);

const RateLimiter = require('limiter').RateLimiter;

Nazaire · 2023-07-25T07:19:33Z

I've worked around it by importing the CJS file explicitly.

import * as limiter from "./node_modules/limiter/dist/cjs/index.js";

It's ugly but it works.

For some reason, node was importing the esm files and treating them to be CJS files.

Looking forward to this being fixed.

brenc · 2023-08-08T07:18:18Z

Ran into this myself. @Nazaire your workaround worked for me. Thank you for posting that.

@jhurliman please let us know if you need help maintaining this project. I would be glad to help.

brenc · 2023-08-09T05:37:48Z

Spoke too soon. @Nazaire's method doesn't work in a library (at least with yarn). Looks like I'll have to use limiter-es6-compat.

nlwillia · 2024-03-20T14:27:49Z

It's a hack, but since the types are wrong, I used patch-package to strip this down to something that would work when installing locally.

limiter+2.1.0.patch

diff --git a/node_modules/limiter/dist/cjs/clock.js b/node_modules/limiter/dist/cjs/clock.js
index afe9ba8..436039f 100644
--- a/node_modules/limiter/dist/cjs/clock.js
+++ b/node_modules/limiter/dist/cjs/clock.js
@@ -1,11 +1,10 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.wait = exports.getMilliseconds = void 0;
-const just_performance_1 = require("just-performance");
 // generate timestamp or delta
 // see http://nodejs.org/api/process.html#process_process_hrtime
 function hrtime(previousTimestamp) {
-    const clocktime = just_performance_1.performance.now() * 1e-3;
+    const clocktime = performance.now() * 1e-3;
     let seconds = Math.floor(clocktime);
     let nanoseconds = Math.floor((clocktime % 1) * 1e9);
     if (previousTimestamp != undefined) {
diff --git a/node_modules/limiter/package.json b/node_modules/limiter/package.json
index 2b05cca..cd28267 100644
--- a/node_modules/limiter/package.json
+++ b/node_modules/limiter/package.json
@@ -3,12 +3,9 @@
   "description": "A generic rate limiter for the web and node.js. Useful for API clients, web crawling, or other tasks that need to be throttled",
   "version": "2.1.0",
   "author": "John Hurliman <[email protected]>",
-  "main": "./dist/cjs/index.js",
-  "module": "./dist/esm/index.js",
-  "browser": "./dist/esm/index.js",
   "exports": {
-    "import": "./dist/esm/index.js",
-    "require": "./dist/cjs/index.js"
+    ".": "./dist/cjs/index.js",
+    "./*.js": "./dist/cjs/*.js"
   },
   "repository": "git://github.com/jhurliman/node-rate-limiter",
   "bugs": {
@@ -24,9 +21,6 @@
     "prepack": "yarn ttsc -p tsconfig.json && ttsc -p tsconfig.cjs.json",
     "test": "jest src"
   },
-  "dependencies": {
-    "just-performance": "4.3.0"
-  },
   "devDependencies": {
     "@babel/core": "^7.13.16",
     "@babel/preset-env": "^7.13.15",

jhurliman · 2024-04-20T09:15:57Z

I have a proposed fix in #96 if anyone wants to test it out before I merge

FabianFrank · 2024-08-13T17:59:12Z

@jhurliman are you planning to publish the fixed version to npm?

alanshaw pushed a commit to nftstorage/nft.storage that referenced this issue May 20, 2021

fix: pin limiter to v2.0.1

107c946

jhurliman/node-rate-limiter#80

alanshaw mentioned this issue May 25, 2021

chore: add lockfile nftstorage/nft.storage#150

Merged

airforce270 added a commit to airforce270/CytubeBot that referenced this issue Jan 2, 2022

Fix deps

c67d0ed

- Upgrade eslint - Lock limiter to 2.0.1 (jhurliman/node-rate-limiter#80)

benschwarz mentioned this issue Apr 13, 2022

Enable ES Module usage #89

Closed

2 tasks

il3ven mentioned this issue Jul 28, 2022

fix import from ES Module #92

Open

sudiptosarkar mentioned this issue Aug 2, 2022

Module cannot be imported in an ES6 Module. jhurliman/just-performance#3

Closed

il3ven mentioned this issue Aug 6, 2022

add rate limiter neume-network/extraction-worker#38

Merged

jhurliman mentioned this issue Apr 20, 2024

Drop just-performance, ttypescript, use *.js imports, create cjs/esm package.json files, bump deps #96

Merged

jhurliman closed this as completed in #96 Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Importing from esm in Node.js is broken in v2.1.0 #80

Importing from esm in Node.js is broken in v2.1.0 #80

alanshaw commented May 20, 2021

olizilla commented Jul 21, 2021 •

edited

Loading

michael-land commented Aug 28, 2021

LandonSchropp commented Oct 21, 2021

Mwni commented Nov 1, 2021

raxod502 commented Dec 22, 2021

nigelis commented Jan 12, 2022

w0rldart commented Jan 17, 2022

cornopaez commented Jan 28, 2022

yarfuo commented Feb 22, 2022

sudiptosarkar commented Aug 2, 2022

kutsan commented Aug 6, 2022

brandonros commented Mar 28, 2023

sudiptosarkar commented Mar 29, 2023

alanshaw commented Apr 25, 2023

shuklaalok7 commented Apr 26, 2023 •

edited

Loading

sudiptosarkar commented May 12, 2023

wayne5540 commented Jun 6, 2023

Nazaire commented Jul 25, 2023 •

edited

Loading

brenc commented Aug 8, 2023

brenc commented Aug 9, 2023

nlwillia commented Mar 20, 2024

jhurliman commented Apr 20, 2024

FabianFrank commented Aug 13, 2024

Importing from esm in Node.js is broken in v2.1.0 #80

Importing from esm in Node.js is broken in v2.1.0 #80

Comments

alanshaw commented May 20, 2021

olizilla commented Jul 21, 2021 • edited Loading

michael-land commented Aug 28, 2021

LandonSchropp commented Oct 21, 2021

Mwni commented Nov 1, 2021

raxod502 commented Dec 22, 2021

nigelis commented Jan 12, 2022

w0rldart commented Jan 17, 2022

cornopaez commented Jan 28, 2022

yarfuo commented Feb 22, 2022

sudiptosarkar commented Aug 2, 2022

kutsan commented Aug 6, 2022

brandonros commented Mar 28, 2023

sudiptosarkar commented Mar 29, 2023

alanshaw commented Apr 25, 2023

shuklaalok7 commented Apr 26, 2023 • edited Loading

sudiptosarkar commented May 12, 2023

wayne5540 commented Jun 6, 2023

Nazaire commented Jul 25, 2023 • edited Loading

brenc commented Aug 8, 2023

brenc commented Aug 9, 2023

nlwillia commented Mar 20, 2024

jhurliman commented Apr 20, 2024

FabianFrank commented Aug 13, 2024

olizilla commented Jul 21, 2021 •

edited

Loading

shuklaalok7 commented Apr 26, 2023 •

edited

Loading

Nazaire commented Jul 25, 2023 •

edited

Loading