This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
Make mod work like gcd #211
Comments
Closed
|
@Happypig375. Fixed! |
|
Ok |
jiggzson
added a commit
that referenced
this issue
Dec 28, 2017
* Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Fix for lcm not being exposed (#328) * Fix integrate(sec(x)^2/(1+tan(x)^2) in progress * Support for itegrate (1+x^2)^-n where n is integer * integrate 1/(x^4+1) in progress ... * Revert "integrate 1/(x^4+1) in progress ..." This reverts commit 5bfb526. * Revert "" This reverts commit 74cbd66. * Revert "Revert """ This reverts commit 97d4741. * integrate u du where u is inv trig * Add code of conduct 1 (#338) * Update 0.7.14 (#325) * Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Create CODE_OF_CONDUCT.md * Fix #335 #267 #272 * Fix for #282 Because this issue spans multiple add-ons a test for this issue could not be added * Implement #330 * Fix issue #121 * Started #218 Fix #147 #199 version bump for add-ons * Possible fix #248 * Possible fix #248 - update * Some complex trig Some factoring More inverse Laplace Fix to invert moved decompose_fn to core Fix to imaginary i^(-n) * more inverse laplace * more inverse Laplace * fix failing test ilt * Fix #346, #348 Address #351 Stopping inverse Laplace. More to be added in future. * Wrapping up #134 * Fix issue #209 Added test for #134 Fix issue #211 Added missing derivatives for functions * Started limits * Make limit invisible Update gcd
Merged
jiggzson
added a commit
that referenced
this issue
Dec 28, 2017
* Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Fix for lcm not being exposed (#328) * Fix integrate(sec(x)^2/(1+tan(x)^2) in progress * Support for itegrate (1+x^2)^-n where n is integer * integrate 1/(x^4+1) in progress ... * Revert "integrate 1/(x^4+1) in progress ..." This reverts commit 5bfb526. * Revert "" This reverts commit 74cbd66. * Revert "Revert """ This reverts commit 97d4741. * integrate u du where u is inv trig * Add code of conduct 1 (#338) * Update 0.7.14 (#325) * Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Create CODE_OF_CONDUCT.md * Fix #335 #267 #272 * Fix for #282 Because this issue spans multiple add-ons a test for this issue could not be added * Implement #330 * Fix issue #121 * Started #218 Fix #147 #199 version bump for add-ons * Possible fix #248 * Possible fix #248 - update * Some complex trig Some factoring More inverse Laplace Fix to invert moved decompose_fn to core Fix to imaginary i^(-n) * more inverse laplace * more inverse Laplace * fix failing test ilt * Fix #346, #348 Address #351 Stopping inverse Laplace. More to be added in future. * Wrapping up #134 * Fix issue #209 Added test for #134 Fix issue #211 Added missing derivatives for functions * Started limits * Make limit invisible Update gcd
jiggzson
pushed a commit
that referenced
this issue
Jan 17, 2018
* Update 0.7.14 (#325) * Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Implement #329 * Update tests * Fix failing test * GCD and LCM fixed & done * Yay, bugfixes! * Remove duplicate nerdamer.core.js * Fix wrong ! usage * Update lcm tests * It is _.error not _.err * Fix for gcd feels counter intuitive but it works. In: gcd((12*x^3+12*x^4+3*x^5+4*x^6+4*x^7+x^8)*(3+x^3), (3+x^3)^2) Previous output: 3+x^3 Current output: 6*x^3+x^6+9 * isVariableSymbol Also happy face in Utils.arguments2array :) * Actually use arguments2Array :) * Fix typo * Determine variable intersection before looking if aggregate is undefined * Change from intersection to haveIntersection * GCD rewritten to match Wolfram Alpha * Also evaluate GCD when all arguments are group N * Support EX in gcd * New tests * Fix all tests except lcm(1/a,1/b,1/c) * lcm(1/a,1/b,1/c) should be fixed * 0.7.15 (#355) * Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Fix for lcm not being exposed (#328) * Fix integrate(sec(x)^2/(1+tan(x)^2) in progress * Support for itegrate (1+x^2)^-n where n is integer * integrate 1/(x^4+1) in progress ... * Revert "integrate 1/(x^4+1) in progress ..." This reverts commit 5bfb526. * Revert "" This reverts commit 74cbd66. * Revert "Revert """ This reverts commit 97d4741. * integrate u du where u is inv trig * Add code of conduct 1 (#338) * Update 0.7.14 (#325) * Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Create CODE_OF_CONDUCT.md * Fix #335 #267 #272 * Fix for #282 Because this issue spans multiple add-ons a test for this issue could not be added * Implement #330 * Fix issue #121 * Started #218 Fix #147 #199 version bump for add-ons * Possible fix #248 * Possible fix #248 - update * Some complex trig Some factoring More inverse Laplace Fix to invert moved decompose_fn to core Fix to imaginary i^(-n) * more inverse laplace * more inverse Laplace * fix failing test ilt * Fix #346, #348 Address #351 Stopping inverse Laplace. More to be added in future. * Wrapping up #134 * Fix issue #209 Added test for #134 Fix issue #211 Added missing derivatives for functions * Started limits * Make limit invisible Update gcd * Updated coeffs to return vector (#352) version bump * Additions to factor * partial fractions * partial fractions continued (univariate only) * partial fractions multivariate working partially * fixed factors not reducing partial fractions * partial fraction complete there are still some issues but those are related to divide * fix #358 * update #358 * Fix wrong closing bracket (#359) * fix #360 partial fractions not complete. Still needs work added degree function * Update #360 Update #351 & added unit tests Partial fractions not complete - In progress * fix #337 - distributeExponent partial fraction - done? * Fully qualify arguments2Array * Make nthroot return Symbol (#361) * Update to integrate. Fix for some invalid results * more integration stopping for now * make complete square available fix to complete square * fix to complete square * some complex numbers needs unit tests * some complex numbers needs unit tests * trig complex done * starting complex hyp trig * update complex trigh tests more complex * wrapping up htrig complex * Added rectform for imaginary numbers * Short-circuit early * Fixed Symbol.getNum && Symbol.getDenom Fixed expand not expanding denominator for group CB Fully moved integrate to partial fractions Starting cleanup of redundant clone calls * Add denominator and numerator * Fix for defint * Fix #331 * Another shot at gcding numer and denom * Fix #362 * Fix #337 denominator issue * Change denom from using lcm to gcd * Some solve * More solve Some solutions cannot be obtained due to limitations with factor * Make denom gcd correct * Fix for getDenom returning Frac instead of Symbol * #363 reborn (#365) * #363 reborn * Subtract and see * Passing tests? * Passing tests! * PASSING TESTS!!!!!!!!!!! * Same CI build# as PR# * nthroot returns decimal on PARSE2NUMBER only fixed even nthroot of negative numbers extended solve for symbolic answers * Fix for getDenom returning Frac instead of Symbol * Fix undefined stuff * Fix for getNum. Again... * Rolling back solve * Try to use lcm in denom again * Fix #285, #366 Higher precision toDecimal * Fix for #337 defint now throws UndefineError if it does not converge to an answer Fix for arg not returning a Symbol * Fix #368 * No need to detect intersection of variables in lcm * Turns out I do need to check duplicate variables * Fix wrong variable name * Revert lcm changes * Fully qualify arrayUnique * Force pass tests for now * temporary fix for solve for cubics * fix Symbol.hyp * update polarform test * evaluating complex * use symbolic layer for nthroot imaginary number special value for factorial * update sort
jiggzson
added a commit
that referenced
this issue
Jan 17, 2018
* Updated coeffs to return vector (#352) version bump * Additions to factor * partial fractions * partial fractions continued (univariate only) * partial fractions multivariate working partially * fixed factors not reducing partial fractions * partial fraction complete there are still some issues but those are related to divide * fix #358 * update #358 * Fix wrong closing bracket (#359) * fix #360 partial fractions not complete. Still needs work added degree function * Update #360 Update #351 & added unit tests Partial fractions not complete - In progress * fix #337 - distributeExponent partial fraction - done? * Make nthroot return Symbol (#361) * Update to integrate. Fix for some invalid results * more integration stopping for now * make complete square available fix to complete square * fix to complete square * some complex numbers needs unit tests * some complex numbers needs unit tests * trig complex done * starting complex hyp trig * update complex trigh tests more complex * wrapping up htrig complex * Added rectform for imaginary numbers * Fixed Symbol.getNum && Symbol.getDenom Fixed expand not expanding denominator for group CB Fully moved integrate to partial fractions Starting cleanup of redundant clone calls * Add denominator and numerator * Fix for defint * Fix #331 * Fix #362 * Fix #337 denominator issue * Some solve * More solve Some solutions cannot be obtained due to limitations with factor * Fix for getDenom returning Frac instead of Symbol * #363 reborn (#365) * #363 reborn * Subtract and see * Passing tests? * Passing tests! * PASSING TESTS!!!!!!!!!!! * Same CI build# as PR# * nthroot returns decimal on PARSE2NUMBER only fixed even nthroot of negative numbers extended solve for symbolic answers * Fix for getDenom returning Frac instead of Symbol * Fix for getNum. Again... * Rolling back solve * Fix #285, #366 Higher precision toDecimal * Fix for #337 defint now throws UndefineError if it does not converge to an answer Fix for arg not returning a Symbol * temporary fix for solve for cubics * fix Symbol.hyp * update polarform test * evaluating complex * use symbolic layer for nthroot imaginary number special value for factorial * update sort * Implement #329 (#337) * Update 0.7.14 (#325) * Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Implement #329 * Update tests * Fix failing test * GCD and LCM fixed & done * Yay, bugfixes! * Remove duplicate nerdamer.core.js * Fix wrong ! usage * Update lcm tests * It is _.error not _.err * Fix for gcd feels counter intuitive but it works. In: gcd((12*x^3+12*x^4+3*x^5+4*x^6+4*x^7+x^8)*(3+x^3), (3+x^3)^2) Previous output: 3+x^3 Current output: 6*x^3+x^6+9 * isVariableSymbol Also happy face in Utils.arguments2array :) * Actually use arguments2Array :) * Fix typo * Determine variable intersection before looking if aggregate is undefined * Change from intersection to haveIntersection * GCD rewritten to match Wolfram Alpha * Also evaluate GCD when all arguments are group N * Support EX in gcd * New tests * Fix all tests except lcm(1/a,1/b,1/c) * lcm(1/a,1/b,1/c) should be fixed * 0.7.15 (#355) * Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Fix for lcm not being exposed (#328) * Fix integrate(sec(x)^2/(1+tan(x)^2) in progress * Support for itegrate (1+x^2)^-n where n is integer * integrate 1/(x^4+1) in progress ... * Revert "integrate 1/(x^4+1) in progress ..." This reverts commit 5bfb526. * Revert "" This reverts commit 74cbd66. * Revert "Revert """ This reverts commit 97d4741. * integrate u du where u is inv trig * Add code of conduct 1 (#338) * Update 0.7.14 (#325) * Added line function * Merge origin/dev into dev Conflicts: Algebra.js fix #119 #246 * fix issue #263 * nthroot in progress... * nthroot done. Needs optimization * Add tests for #55 and #294 (#323) * Fix issue #321 * Fix issue #247 * minor fixes * Update solve test * Create CODE_OF_CONDUCT.md * Fix #335 #267 #272 * Fix for #282 Because this issue spans multiple add-ons a test for this issue could not be added * Implement #330 * Fix issue #121 * Started #218 Fix #147 #199 version bump for add-ons * Possible fix #248 * Possible fix #248 - update * Some complex trig Some factoring More inverse Laplace Fix to invert moved decompose_fn to core Fix to imaginary i^(-n) * more inverse laplace * more inverse Laplace * fix failing test ilt * Fix #346, #348 Address #351 Stopping inverse Laplace. More to be added in future. * Wrapping up #134 * Fix issue #209 Added test for #134 Fix issue #211 Added missing derivatives for functions * Started limits * Make limit invisible Update gcd * Updated coeffs to return vector (#352) version bump * Additions to factor * partial fractions * partial fractions continued (univariate only) * partial fractions multivariate working partially * fixed factors not reducing partial fractions * partial fraction complete there are still some issues but those are related to divide * fix #358 * update #358 * Fix wrong closing bracket (#359) * fix #360 partial fractions not complete. Still needs work added degree function * Update #360 Update #351 & added unit tests Partial fractions not complete - In progress * fix #337 - distributeExponent partial fraction - done? * Fully qualify arguments2Array * Make nthroot return Symbol (#361) * Update to integrate. Fix for some invalid results * more integration stopping for now * make complete square available fix to complete square * fix to complete square * some complex numbers needs unit tests * some complex numbers needs unit tests * trig complex done * starting complex hyp trig * update complex trigh tests more complex * wrapping up htrig complex * Added rectform for imaginary numbers * Short-circuit early * Fixed Symbol.getNum && Symbol.getDenom Fixed expand not expanding denominator for group CB Fully moved integrate to partial fractions Starting cleanup of redundant clone calls * Add denominator and numerator * Fix for defint * Fix #331 * Another shot at gcding numer and denom * Fix #362 * Fix #337 denominator issue * Change denom from using lcm to gcd * Some solve * More solve Some solutions cannot be obtained due to limitations with factor * Make denom gcd correct * Fix for getDenom returning Frac instead of Symbol * #363 reborn (#365) * #363 reborn * Subtract and see * Passing tests? * Passing tests! * PASSING TESTS!!!!!!!!!!! * Same CI build# as PR# * nthroot returns decimal on PARSE2NUMBER only fixed even nthroot of negative numbers extended solve for symbolic answers * Fix for getDenom returning Frac instead of Symbol * Fix undefined stuff * Fix for getNum. Again... * Rolling back solve * Try to use lcm in denom again * Fix #285, #366 Higher precision toDecimal * Fix for #337 defint now throws UndefineError if it does not converge to an answer Fix for arg not returning a Symbol * Fix #368 * No need to detect intersection of variables in lcm * Turns out I do need to check duplicate variables * Fix wrong variable name * Revert lcm changes * Fully qualify arrayUnique * Force pass tests for now * temporary fix for solve for cubics * fix Symbol.hyp * update polarform test * evaluating complex * use symbolic layer for nthroot imaginary number special value for factorial * update sort
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Continuation of #137
For variables, it currently will not evaluate: mod(2x+2y,x+y)
It should return 0, like gcd returning x+y.
The text was updated successfully, but these errors were encountered: