Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"wrong" hue of blue for France and the Netherlands #23

Open
paolocrosetto opened this issue Dec 11, 2022 · 2 comments
Open

"wrong" hue of blue for France and the Netherlands #23

paolocrosetto opened this issue Dec 11, 2022 · 2 comments
Milestone

Comments

@paolocrosetto
Copy link

Hi there,

I used your wonderful package to produce a plot that went viral on Twitter.

Dutch people are complaining that the NL flag is actually the Luxembourg flag. See for instance here: https://twitter.com/reinier_boon/status/1601625443530334208?s=20&t=n53cl8O-LT0uz27vCy0iOw

I realized the same lighter-blue-where-darker-blue-should-have-been problem is there for France too.

And nothing, just raising this here as I have no way of fixing this downstream.

Thank you for your work!

@jimjam-slam
Copy link
Owner

Thanks very much for the report! We've had a few reports of wrong flag colours. They've been patched manually thus far, as the source emoji set (EmojiOne Color) stopped being updated a while ago. (That has other problems that stack up over time, as you can imagine, like flags or countries changing outright!)

I'm hoping to do a 1.0 release for ggflag where we switch the backend to a different set of SVG tools, as I've started having problems with the backend scripts where we update flags.

I think it probably makes sense to use that opportunity to update the source flag dataset! I'm eyeing up https://github.com/HatScripts/circle-flags as a potential candidate (See #17), as it's one of the few sets of circular flags.

Thank you for your patience on this!

@jimjam-slam jimjam-slam added this to the version 1.0 milestone Dec 11, 2022
@jimjam-slam
Copy link
Owner

(And congratulations on the popularity of the graphic! 🥳)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants