Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will the Pydantic dependency be upgraded in the future?Currently, due to version issues, some third-party packages are incompatible. #6125

Open
wangqn1 opened this issue Dec 7, 2023 · 18 comments · May be fixed by #6150

Comments

@wangqn1
Copy link

wangqn1 commented Dec 7, 2023

Describe the feature

Your proposal


Environment

Currently, due to version issues, some third-party packages are incompatible.

Screenshots

@JoanFM
Copy link
Member

JoanFM commented Dec 7, 2023

Hey @wangqn1, we plan to upgrade it, but it is quite some work and we do not have capacity at the miment. Specially since we want to mantain compatibility for both Pydantic v2 and pydantic v1.

May I ask what other packages Jina is not compatible with?

@wangqn1
Copy link
Author

wangqn1 commented Dec 14, 2023

some engine classes defined by ourselves

@wangqn1
Copy link
Author

wangqn1 commented Dec 14, 2023

I have Another question, please tell me how to use Java to call Jina's gRPC protocol interface. @JoanFM

@JoanFM
Copy link
Member

JoanFM commented Dec 14, 2023

Hey @wangqn1,

You could build the gRPC services in Java from the proto files that u can find in jina/proto folder.

@wangqn1
Copy link
Author

wangqn1 commented Dec 14, 2023

Hi @JoanFM ,
After compiling two proto files from jina/jina/proto/docarray_v1 into Java files using protoc, I didn't find the corresponding gRPC service interface in jina.java. Could you please help me identify the issue?
docarray_java
jina_java

jdk version: 1.8

@JoanFM
Copy link
Member

JoanFM commented Dec 14, 2023

I am not an expert on how it works for Java, but there should be some documentation about how to buuld the services and clients as well

@JoanFM JoanFM linked a pull request Mar 7, 2024 that will close this issue
1 task
@jina-bot
Copy link
Member

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@jina-bot jina-bot added the Stale label Mar 14, 2024
@ifdown
Copy link

ifdown commented Mar 14, 2024

Hey @wangqn1, we plan to upgrade it, but it is quite some work and we do not have capacity at the miment. Specially since we want to mantain compatibility for both Pydantic v2 and pydantic v1.

May I ask what other packages Jina is not compatible with?

The latest weaviate client requires pydantic v2.

@wangqn1
Copy link
Author

wangqn1 commented Mar 14, 2024 via email

@JoanFM
Copy link
Member

JoanFM commented Mar 14, 2024

Hey @wangqn1, I am putting some work on it. I have identified an issue in docarray that may ease the process.

@JoanFM JoanFM reopened this Mar 29, 2024
@JoanFM JoanFM removed the Stale label Mar 29, 2024
@jina-bot
Copy link
Member

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@jina-bot jina-bot added the Stale label Jun 28, 2024
@JoanFM JoanFM removed the Stale label Jun 28, 2024
@robbym-dev
Copy link

Have there been any updates on a possible fix w/ Pydantic v2? Currently trying to pip install together, but there is a pydantic version conflict w/ no workaround.

Thanks for the help you have given thus far!

@JoanFM
Copy link
Member

JoanFM commented Jul 3, 2024

Hello @robbym-dev ,

There is no update so far.

Any news on the approach @wangqn1 ?

@robbym-dev
Copy link

Hi @JoanFM,

Thank you for the response.

Do you know of any other possible workarounds? The primary conflict is w/ together.ai's pip package, it requires pydantic>2.0.0, while Jina requires pydantic<1.0.0.

Making a separate conda environment isn't feasible since I am making a full-fledged pip package for users to install in our framework, and requiring users to make a seperate conda environment isn't realistic.

Please let me know, thank you so much for your assistance so far on the issue!

@JoanFM
Copy link
Member

JoanFM commented Jul 8, 2024

Hello @robbym-dev ,

I am not so sure, perhaps we can have a short meeting to understand the problematic and see wether or not there is a workaround.

Thanks,

Joan

@robbym-dev
Copy link

Hi @JoanFM

I would love to get on a short meeting to discuss a possible workaround. I sent you an email to coordinate this.

Thank you again,
Robby

@mmclure
Copy link

mmclure commented Aug 17, 2024

May I ask what other packages Jina is not compatible with?

The latest weaviate client requires pydantic v2.

Also the latest DSPy, I think.

@jina-bot
Copy link
Member

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@jina-bot jina-bot added the Stale label Nov 16, 2024
@JoanFM JoanFM removed the Stale label Nov 30, 2024
@JoanFM JoanFM reopened this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants