From a113d81e550d5ea3603c45d2ec20494b4daa13bf Mon Sep 17 00:00:00 2001 From: Evgeny Gorbovoy Date: Fri, 29 Nov 2024 21:44:07 +0100 Subject: [PATCH 1/3] CA2007 to editorconfig --- src/.editorconfig | 1 + src/Consolonia.Core/Consolonia.Core.csproj | 5 +---- src/Consolonia.GuiCS/Consolonia.GuiCS.csproj | 1 - src/Consolonia.NUnit/Consolonia.NUnit.csproj | 1 - .../Consolonia.PlatformSupport.csproj | 4 ---- .../Consolonia.Themes.TurboVision.csproj | 4 ---- src/Tests/Consolonia.Core.Tests/Consolonia.Core.Tests.csproj | 1 - src/Tests/Consolonia.Core.Tests/StorageTests.cs | 1 - .../Consolonia.Gallery.Tests/Consolonia.Gallery.Tests.csproj | 1 - 9 files changed, 2 insertions(+), 17 deletions(-) diff --git a/src/.editorconfig b/src/.editorconfig index 45b7f78a..dc887c0f 100644 --- a/src/.editorconfig +++ b/src/.editorconfig @@ -74,6 +74,7 @@ dotnet_diagnostic.ca1043.severity = none # todo: why not to use indexer rather t dotnet_diagnostic.ca1814.severity = none # sometimes we need rectangle array dotnet_diagnostic.ca1058.severity = none # check why new documentation warns not to derive from ApplicationException. The purpose of last is to distinguish system exceptions like OOM, AssemblyLoadException etc from application logic dotnet_diagnostic.ca2000.severity = none # exceptions which are listed in the rule can be applied to any type +dotnet_diagnostic.CA2007.severity = none # we are assuming task continuation thread is fine by default dotnet_diagnostic.ca2213.severity = none # keeping field does not mean necessarity to dispose - it can be dispose somwhere else dotnet_diagnostic.ca2248.severity = none # https://github.com/dotnet/roslyn-analyzers/issues/4432 dotnet_diagnostic.ca1062.severity = none # we are fine with NRE - no need for additional checks diff --git a/src/Consolonia.Core/Consolonia.Core.csproj b/src/Consolonia.Core/Consolonia.Core.csproj index 18dd6b13..d059e8af 100644 --- a/src/Consolonia.Core/Consolonia.Core.csproj +++ b/src/Consolonia.Core/Consolonia.Core.csproj @@ -1,8 +1,5 @@ - - - CA2007; - + diff --git a/src/Consolonia.GuiCS/Consolonia.GuiCS.csproj b/src/Consolonia.GuiCS/Consolonia.GuiCS.csproj index 8444456a..63547ffb 100644 --- a/src/Consolonia.GuiCS/Consolonia.GuiCS.csproj +++ b/src/Consolonia.GuiCS/Consolonia.GuiCS.csproj @@ -3,6 +3,5 @@ false false false - CA2007; diff --git a/src/Consolonia.NUnit/Consolonia.NUnit.csproj b/src/Consolonia.NUnit/Consolonia.NUnit.csproj index f80b7dce..dae1791f 100644 --- a/src/Consolonia.NUnit/Consolonia.NUnit.csproj +++ b/src/Consolonia.NUnit/Consolonia.NUnit.csproj @@ -4,7 +4,6 @@ true - CA2007; diff --git a/src/Consolonia.PlatformSupport/Consolonia.PlatformSupport.csproj b/src/Consolonia.PlatformSupport/Consolonia.PlatformSupport.csproj index 95b120dd..67b5a320 100644 --- a/src/Consolonia.PlatformSupport/Consolonia.PlatformSupport.csproj +++ b/src/Consolonia.PlatformSupport/Consolonia.PlatformSupport.csproj @@ -1,10 +1,6 @@ - - CA2007; - - diff --git a/src/Consolonia.Themes.TurboVision/Consolonia.Themes.TurboVision.csproj b/src/Consolonia.Themes.TurboVision/Consolonia.Themes.TurboVision.csproj index e0a8d098..0a5c6c47 100644 --- a/src/Consolonia.Themes.TurboVision/Consolonia.Themes.TurboVision.csproj +++ b/src/Consolonia.Themes.TurboVision/Consolonia.Themes.TurboVision.csproj @@ -2,10 +2,6 @@ - - CA2007; - - diff --git a/src/Tests/Consolonia.Core.Tests/Consolonia.Core.Tests.csproj b/src/Tests/Consolonia.Core.Tests/Consolonia.Core.Tests.csproj index 350706ed..63d154b2 100644 --- a/src/Tests/Consolonia.Core.Tests/Consolonia.Core.Tests.csproj +++ b/src/Tests/Consolonia.Core.Tests/Consolonia.Core.Tests.csproj @@ -4,7 +4,6 @@ false - CA2007; diff --git a/src/Tests/Consolonia.Core.Tests/StorageTests.cs b/src/Tests/Consolonia.Core.Tests/StorageTests.cs index 03892957..c82c6afa 100644 --- a/src/Tests/Consolonia.Core.Tests/StorageTests.cs +++ b/src/Tests/Consolonia.Core.Tests/StorageTests.cs @@ -1,4 +1,3 @@ -#pragma warning disable CA2007 // Consider calling ConfigureAwait on the awaited task // ReSharper disable PossibleNullReferenceException // ReSharper disable ConstantConditionalAccessQualifier using System; diff --git a/src/Tests/Consolonia.Gallery.Tests/Consolonia.Gallery.Tests.csproj b/src/Tests/Consolonia.Gallery.Tests/Consolonia.Gallery.Tests.csproj index dc977029..8715e73d 100644 --- a/src/Tests/Consolonia.Gallery.Tests/Consolonia.Gallery.Tests.csproj +++ b/src/Tests/Consolonia.Gallery.Tests/Consolonia.Gallery.Tests.csproj @@ -2,7 +2,6 @@ false - CA2007; From 4e8826e9dbf9f1bf2e726fd193f4c2ec504d996e Mon Sep 17 00:00:00 2001 From: Evgeny Gorbovoy Date: Fri, 29 Nov 2024 21:47:22 +0100 Subject: [PATCH 2/3] NoWant for AVA3001 --- Directory.Build.props | 1 + 1 file changed, 1 insertion(+) diff --git a/Directory.Build.props b/Directory.Build.props index 31a7bf2b..c61df258 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -9,6 +9,7 @@ https://github.com/jinek/Consolonia/graphs/contributors Text User Interface implementation of Avalonia UI (GUI Framework) Copyright © Evgeny Gorbovoy 2021 - 2022 + AVA3001 11.0.9 From 781b71c3dba8eb56d463913345d7b5f45978c6f8 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 29 Nov 2024 21:37:00 +0000 Subject: [PATCH 3/3] Automated JetBrains cleanup Co-authored-by: <+@users.noreply.github.com> --- src/Tests/Consolonia.Core.Tests/StorageTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Tests/Consolonia.Core.Tests/StorageTests.cs b/src/Tests/Consolonia.Core.Tests/StorageTests.cs index c82c6afa..ec85480f 100644 --- a/src/Tests/Consolonia.Core.Tests/StorageTests.cs +++ b/src/Tests/Consolonia.Core.Tests/StorageTests.cs @@ -1,5 +1,6 @@ // ReSharper disable PossibleNullReferenceException // ReSharper disable ConstantConditionalAccessQualifier + using System; using System.Globalization; using System.IO;