Skip to content
This repository has been archived by the owner on Oct 11, 2018. It is now read-only.

Made parameter package_provider optional. #133

Merged
merged 1 commit into from
Feb 23, 2015
Merged

Conversation

schkovich
Copy link
Collaborator

In addition to making parameter package_provider optional I wrote basic tests for related classes.
Note change in spec/classes/php_spec.rb on line 5. Example was failing with

TypeError: no implicit conversion of Symbol into Hash
/home/goran/.gem/ruby/2.2.0/gems/rspec-puppet-2.0.0/lib/rspec-puppet/matchers/include_class.rb:7:in `block (2 levels) in <module:ManifestMatchers>'
./spec/classes/php_spec.rb:6:in `block (2 levels) in <top (required)>'

include_class matcher was deprecated in rspec-puppet 1.0 and later on removed. As advised I used contain_class instead.
close #131

@igalic
Copy link
Collaborator

igalic commented Feb 23, 2015

please note that i've done that in commit 2 of #116, which i'd still really like to see some reviews for!

@schkovich
Copy link
Collaborator Author

@igalic I am not following you. You are referring to de013c1? I can't see any overlapping with with a0dab92. :(

@joshbetz
Copy link
Contributor

👍 This should fix my issue.

@igalic
Copy link
Collaborator

igalic commented Feb 23, 2015

@schkovich gosh you're right, i'm sorry

@jippi
Copy link
Owner

jippi commented Feb 23, 2015

👍 I like it

igalic added a commit that referenced this pull request Feb 23, 2015
Made parameter package_provider optional.
@igalic igalic merged commit f3e9c84 into jippi:master Feb 23, 2015
@schkovich
Copy link
Collaborator Author

no worries @igalic :)

@joshbetz
Copy link
Contributor

Still seeing this error :(

Must pass provider to Class[Php::Fpm::Service]

@schkovich schkovich deleted the fpm branch February 25, 2015 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants