Skip to content
This repository has been archived by the owner on Oct 11, 2018. It is now read-only.

Exensions Installed Using Pecl Provider are not Enabled #148

Closed
wants to merge 19 commits into from

Conversation

schkovich
Copy link
Collaborator

A proposal on how to tackle the problem in a bit more generic way. It's mixture of @jippi's idea given in issue #74 thread, @igalic's solution given in #116 and a workaround the hiera and php5(dis)enable incomparability problem described in bug #783246.

Related: #142 #139 #102 #76 #74

@schkovich schkovich changed the title Exensions Installed Pecl Provider are not Enabled Exensions Installed Using Pecl Provider are not Enabled Apr 27, 2015
@jippi
Copy link
Owner

jippi commented Apr 27, 2015

looks legit to me :)

@schkovich
Copy link
Collaborator Author

Well, it does look legit. :) However, it would be good to define a type that will encapsulate command creation/execution logic depending on PHP version. It will be nice to create unit tests as well. Finally there are twenty commits referencing each step I made. None of those commits have a place in upstream/master. Except the last one of course. :)

@jippi
Copy link
Owner

jippi commented Apr 28, 2015

What do you think @igalic ?

@igalic
Copy link
Collaborator

igalic commented Apr 30, 2015

needs squash


I'm not happy with disenable as name, but eh. there's worse ;)
i'd also like to see some mild documentation, or at least warning (or fail) that it's a private type which shouldn't be used.

@schkovich
Copy link
Collaborator Author

@igalic I am not happy with disenable either. I would gladly change if you can come with better one.

Aside from documentation I would add tests as well.

Absolutely, squash is mandatory. I did not intend to create pull request but provide a example to discuss.

@igalic
Copy link
Collaborator

igalic commented May 26, 2015

@schkovich perhaps i should also have mentioned that other than the criticism, i'm actually quite happy with the way this is taking.

@schkovich schkovich mentioned this pull request Feb 19, 2016
schkovich added a commit to schkovich/puppet-php that referenced this pull request Feb 19, 2016
@schkovich
Copy link
Collaborator Author

squashed version of this change in #162

@igalic I did not get a better name. :( I added doc blocks and assert_private.

@schkovich schkovich closed this Feb 19, 2016
@schkovich schkovich mentioned this pull request Feb 19, 2016
vpassapera pushed a commit to vpassapera/puppet-php that referenced this pull request Oct 21, 2016
vpassapera pushed a commit to vpassapera/puppet-php that referenced this pull request Oct 21, 2016
schkovich added a commit that referenced this pull request Mar 19, 2017
* Mix and match various proposals.

* Parameters classes must be included.

refs #142

* Added doc blox and assert_private.

refs  #148
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants