-
Notifications
You must be signed in to change notification settings - Fork 87
Exensions Installed Using Pecl Provider are not Enabled #148
Conversation
looks legit to me :) |
Well, it does look legit. :) However, it would be good to define a type that will encapsulate command creation/execution logic depending on PHP version. It will be nice to create unit tests as well. Finally there are twenty commits referencing each step I made. None of those commits have a place in upstream/master. Except the last one of course. :) |
What do you think @igalic ? |
needs squash I'm not happy with disenable as name, but eh. there's worse ;) |
@igalic I am not happy with disenable either. I would gladly change if you can come with better one. Aside from documentation I would add tests as well. Absolutely, squash is mandatory. I did not intend to create pull request but provide a example to discuss. |
@schkovich perhaps i should also have mentioned that other than the criticism, i'm actually quite happy with the way this is taking. |
A proposal on how to tackle the problem in a bit more generic way. It's mixture of @jippi's idea given in issue #74 thread, @igalic's solution given in #116 and a workaround the hiera and php5(dis)enable incomparability problem described in bug #783246.
Related: #142 #139 #102 #76 #74