Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes show for staged files with latest update #311

Closed
reconbot opened this issue Sep 3, 2016 · 5 comments
Closed

Changes show for staged files with latest update #311

reconbot opened this issue Sep 3, 2016 · 5 comments

Comments

@reconbot
Copy link

reconbot commented Sep 3, 2016

I'm on git gutter v1.3.0, with this latest update I'm seeing changes for files, changes that have been staged for commit. Previous versions did not show these differences, an option would be great.

Thanks! Great plugin!

@sigod
Copy link
Collaborator

sigod commented Sep 3, 2016

What do you exactly mean? Nothing changed for me, but GitGutter was always showing +s for newly added files after they being staged.

@rchl
Copy link
Collaborator

rchl commented Nov 15, 2016

As @sigod said, it was like that all along. There is an old issue #118 about differentiating staged and ustaged files.

@rchl rchl closed this as completed Nov 15, 2016
@jisaacks
Copy link
Owner

@rchl I still have a fairly big staged branch where I was working on differentiating between staged and unstaged commits. It was looking promising but also becoming a pretty complex problem.

It's been a while since I touched it so the details are foggy at this point but you are welcome to poke around it if it peaks your interest. Might not be worth the complexity though.

@rchl
Copy link
Collaborator

rchl commented Nov 15, 2016

Yes, saw that. It's mentioned in that issue.
But I can't promise that I will have enough interest to look into it myself. :)

@jisaacks
Copy link
Owner

But I can't promise that I will have enough interest

Oh no worries at all! I wasn't trying to push it on you.

BTW, you are killing it, loving how much you have been contributing. Thanks so much for all your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants