-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change font on popups #577
Comments
"Blame" uses ST's annotation API. GitGutter doesn't assign explicit font-family settings to it. The font is choosen by ST or any CSS embedded in the active color scheme. By default ST should pick the font from preferences. I already saw Times New Roman being applied, too, but never found out the root cause. Font name is a global setting, which would effect any plugin using annotations api. Hence it doesn't make sense to introduce a font-family setting to adjust it for GitGutter only. Diff popup also uses a view's font to display diffs. Font is set only for toolbar glyphs. Diff popup can be modified via I am able to adjust "diff" fonts via: /* GitGutter Popup Stylesheet - User */
.git-gutter div.highlight {
font-family: Arial;
} It not working on your end, may be caused by the same reason for Times New Roman being selected for annotations. |
So here is an interesting thing...
which will pick up the desired font and change it globally, but inline/popups will NOT accept it as if it cannot find the font (which seems to be consistent with other posts on the web having similar issue). Note, all the fonts are instanced in custom font Mac path, so should be visible. When I comment the the line out So I am kind of clueless why would custom font work globally except popups and inline 🤔 As if ST is not picking up the new custom-default font. |
Yeah, and I did try diff options for GitGutter and I do not see any relevant changes :( |
That's however nothing related to GitGutter. Maybe another package or color scheme messes around with ST has known limitations with regards to correctly cascade multiple stylesheets or picking up changes from color_scheme's CSS settings. Related core issues are:
Notes: All popups/annotations pick up correct fonts on my machine. Diff Popups are rendered by |
Without in-depth testing, this is the assumption and wild guess I make, so thanks for verifying. When I have a minute I might look more into it, for now I guess the default font is fine for me. Thanks for following up 🙏 |
I would like to have an option to change the font on the inline blame popups as well as on the window popups. I tried to toy with the
css
popup stylesheet file, but no success :(In particular what is annoying, for some reason it picks up by default a Times font, which definitely is not my prime choice:
![inline](https://private-user-images.githubusercontent.com/4711498/241279642-557623d5-d49b-44d6-832b-77df0c035265.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4MjM2NjUsIm5iZiI6MTczODgyMzM2NSwicGF0aCI6Ii80NzExNDk4LzI0MTI3OTY0Mi01NTc2MjNkNS1kNDliLTQ0ZDYtODMyYi03N2RmMGMwMzUyNjUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDZUMDYyOTI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjhhYzcyYTMwZDVkY2EzM2I4OWNlMzNmYTIzMGQ5NWM5MzZjMzViZmMzOGVjY2NiNzY3MTZmZDY4NzZiZmVkYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.gRywWLkcELbnuUCGi8vKjl3FCZrbqTbg8STeBIkIlZM)
I would like to be able to change the font to my liking.
The text was updated successfully, but these errors were encountered: