Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosing order of checks? #209

Open
knovoselic opened this issue Apr 2, 2015 · 4 comments
Open

Choosing order of checks? #209

knovoselic opened this issue Apr 2, 2015 · 4 comments

Comments

@knovoselic
Copy link
Contributor

Is there a way to define order in which checks are executed? For example, I'd like to run to run ci check (pre_commit:ci rake task) last because it takes the longest.

@mpapis
Copy link
Collaborator

mpapis commented Apr 2, 2015

@knovoselic
Copy link
Contributor Author

I'm using YAML for configuration (config/pre_commit.yml) and ci is last in checks_add array, but it still gets executed first (or at least before rubocop). Am I missing something?

@mpapis
Copy link
Collaborator

mpapis commented Apr 2, 2015

@jish it's a bug or feature request?

@jish
Copy link
Owner

jish commented Apr 2, 2015

I guess we've always just hard coded an order in the past.

I'm ok with changing the order for everyone and / or making the order configurable.

Josh

On Apr 2, 2015, at 04:58, Michal Papis [email protected] wrote:

@jish it's a bug or feature request?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants