Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP_CodeSniffer pre-commit hook #54

Closed
mikedfunk opened this issue Mar 5, 2013 · 7 comments
Closed

PHP_CodeSniffer pre-commit hook #54

mikedfunk opened this issue Mar 5, 2013 · 7 comments

Comments

@mikedfunk
Copy link
Contributor

It would be great if I could test my PHP code to PSR2 standards via pre-commit. Here is a git repo that already does this, but I couldn't figure out how to apply that check in addition to all the stuff from the pre-commit repo.

@grosser
Copy link
Collaborator

grosser commented Jul 19, 2013

Structure is easier now, give it a try :)

@mpapis
Copy link
Collaborator

mpapis commented Sep 6, 2014

also good thing for #176

@mpapis
Copy link
Collaborator

mpapis commented Oct 5, 2014

@mikedfunk please have a look at this example https://github.com/pre-commit-plugins/pre-commit-php - let me know if you need help with implementing it

@mikedfunk
Copy link
Contributor Author

@mpapis thanks but this is not PHP_CodeSniffer, it's php lint which was already an option in the pre-commit gem.

@mpapis
Copy link
Collaborator

mpapis commented Oct 6, 2014

@mikedfunk I meant it only as example how to implement it, you could copy paste this gem and replace it's php specific code parts with PHP_CodeSniffer - you are the most skilled person to implement this check as you have experience with PHP_CodeSniffer, please let me know if you need help with the ruby parts of the gem, I'm available on irc(#mpapis), skype(michal_papis) and google-talk([email protected]).

@mikedfunk
Copy link
Contributor Author

@mpapis oh cool, thanks. I will check it out when I get the chance.

@mpapis
Copy link
Collaborator

mpapis commented Jan 7, 2015

closing as there was no feedback in over two months, please let us know if you can provide more details and we will reopen

@mpapis mpapis closed this as completed Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants