Change from JS to native Google Calendar Template system to fix bug?

[phlbnks]

When creating an Event in Google Calendar there is a known bug where it doesn't work / works only erratically. Fundamentally this problem is caused by trying to interact with the Calendar page with JS instead of using the native Template system. I propose moving to the native URL var based Template instead to fix this (I have it working in a private fork). Would you be open to a Pull Request for this?

Implications / how I have it working currently:

• create a new config.js to store the constants used in the JS and share across popup.js and meet-calendar.js
• in popup.html load config.js, RandomUtil.js and RoomnameGenerator.js
• in popup.html use (e.g.) https://www.google.com/calendar/render?action=TEMPLATE&autoCreateMeeting=true&details={MEET_DESCRIPTION}&location={MEET_LOCATION}&dates={DATETIME}%2F{DATETIME} as the URL
• in popup.js build vars and replace placeholders
  Unfortunately since I don't think Outlook has an equivalent we still need the extid system, but only for OWA. So either popup.js switches depending on URL or '&extid=' + chrome.runtime.id get's injected in popup.html instead.

[damencho]

Thanks, if you have it handy you can push a PR, thanks.

[phlbnks]

Yes no problem - it'll probably be over the weekend

[phlbnks]

Submitted for review @damencho - let me know if you want any changes or feel free to modify.

[damencho]

What is the state of this PR?

• in popup.js build vars and replace placeholders
  Unfortunately since I don't think Outlook has an equivalent we still need the extid system, but only for OWA. So either popup.js switches depending on URL or '&extid=' + chrome.runtime.id get's injected in popup.html instead.

Is this implemented?

Thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would, unfortunately, be unable to merge your patch unless we have that piece :(.

[phlbnks]

I've signed the ICLA

Looking at the commit it looks like it's missing the &extid=' + chrome.runtime.id for Outlook part, I imagine I was waiting for input on which way to solve it.

I may be able to come back to this but current commitments and the fact I don't run it the extension currently means it may take a while