Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new macOS screen capture when we have Chromium >= 120 #934

Closed
saghul opened this issue Dec 1, 2023 · 5 comments · Fixed by #952
Closed

Enable new macOS screen capture when we have Chromium >= 120 #934

saghul opened this issue Dec 1, 2023 · 5 comments · Fixed by #952
Labels
macOS Issues affecting macOS

Comments

@saghul
Copy link
Member

saghul commented Dec 1, 2023

chromium/chromium@843de71

@csett86
Copy link
Member

csett86 commented Dec 1, 2023

Electron 28 (due 5 dec) should already contain Chromium 120 :)

@csett86
Copy link
Member

csett86 commented Jan 21, 2024

I think just Chromium 120 is probably not enough, as I have not seen any traces in electron for this.

See eg electron/electron#38722

@saghul
Copy link
Member Author

saghul commented Jan 22, 2024

That is different. The Chomium side is about using ScreenCaptureKit for capture, which is supposed to be more efficient and bring back content hiding, which was lost somewhere along the way IIRC: https://developer.apple.com/documentation/screencapturekit?language=objc

@csett86
Copy link
Member

csett86 commented Jan 22, 2024

Ok, then I got them mixed up. Is there anything we need to do, as we have Chromium 120 now as part of electron 28?

@saghul
Copy link
Member Author

saghul commented Jan 22, 2024

I think not!

@csett86 csett86 added the macOS Issues affecting macOS label Jan 28, 2024
@csett86 csett86 linked a pull request Mar 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Issues affecting macOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants