Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acr_values defined as options but not passed #51

Open
treffiletti opened this issue May 31, 2016 · 1 comment
Open

acr_values defined as options but not passed #51

treffiletti opened this issue May 31, 2016 · 1 comment

Comments

@treffiletti
Copy link

So I've had to pass acr_values to the OP and although these are defined as options OmniAuth::Strategies::OpenIDConnect class they are never passed to the final authorize URI. I've included them inside lib/omniauth/strategies/openid_connect.rb on line 127 like so:

      def authorize_uri
        client.redirect_uri = client_options.redirect_uri
        opts = {
            response_type: options.response_type,
            scope: options.scope,
            state: new_state,
            nonce: (new_nonce if options.send_nonce),
            hd: options.hd,
            acr_values: options.acr_values # here is the line
        }
        client.authorization_uri(opts.reject{|k,v| v.nil?})
      end

To my understanding this authorize URI should be flexible enough to include any option that could be passed in the authorize_uri not just the acr_values. Was there a reason this wasn't included in this version or am I missing something?

@harmjanblok
Copy link

Do you want to specify claims, or did I misunderstand you? To be able to specify claims I've created a pull request (#52) some days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants