Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saml Assertion signature verification can be fooled #8

Open
jhudsoncedaron opened this issue Sep 23, 2019 · 1 comment
Open

Saml Assertion signature verification can be fooled #8

jhudsoncedaron opened this issue Sep 23, 2019 · 1 comment
Labels
investigate investigating

Comments

@jhudsoncedaron
Copy link

The signature handling code does not pass the list of signed xml fragments to the signature reader in any way. It can be fooled by a document constructed as follows:

<!-- envelope omitted for brevity -->
<samlp:Assertion>
     <samlp:Assertion>
        <!-- original signature here -->
     <samlp:Assertion>
     <!-- whatever you want -->
</samlp:Assertion>
@jkmu jkmu added the bug Something isn't working label Sep 24, 2019
@jkmu jkmu added investigate investigating and removed bug Something isn't working labels Oct 3, 2019
@RemcovandenBerg
Copy link

Some extra info perhaps and mitigations described in a research paper:
https://www.nds.ruhr-uni-bochum.de/media/nds/veroeffentlichungen/2012/08/22/BreakingSAML_3.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigate investigating
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RemcovandenBerg @jhudsoncedaron @jkmu