Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use selector slicing in ADJACENT selector #299

Open
jleclanche opened this issue Jan 31, 2016 · 1 comment
Open

Use selector slicing in ADJACENT selector #299

jleclanche opened this issue Jan 31, 2016 · 1 comment
Labels

Comments

@jleclanche
Copy link
Owner

In ADJACENT() and Rolling Boulder, we should use selector slicing which would make LEFT_OF and RIGHT_OF selectors select all minions to the left/right of the selector instead of just the first one.

@jleclanche jleclanche added the dsl label Jan 31, 2016
@smallnamespace
Copy link
Collaborator

@jleclanche

How does that interact with child selectors that return multiple items? E.g. if we have:

1 2 X 4 5 X 7 8

where X is the child selector, then left currently picks out 2 and 5 -- you would prefer it selected the entire 1-5 range?

For example, LEFT_OF(X) evaluates to the same result as ALL_LEFT_OF(X)[-1] only in the case where X has a single element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants