New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security - Log messages leak access token #29

Open

jlewi opened this issue May 18, 2023 · 0 comments

Owner

jlewi commented May 18, 2023

Log commands from the shelling out to git messages can leak the access token e.g.

{"level":"error","ts":1684375173.299407,"caller":"util/exec.go:39","msg":"Shell command failed","ManifestSync.Name":"hydros-dev-takeover","run":"9ac0b","command":"/opt/homebrew/bin/git clone https://x-access-token:<TOKEN> ....

This might be fixed by updating syncer to use go-git rather than shelling out to git.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment