Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use viper for configuration #31

Open
jlewi opened this issue May 18, 2023 · 1 comment
Open

Use viper for configuration #31

jlewi opened this issue May 18, 2023 · 1 comment

Comments

@jlewi
Copy link
Owner

jlewi commented May 18, 2023

It might be nice if we could support configuring the GitHubApp from a configuration file rather than having a huge number of command line flags; like Palantir GitHubApps
https://github.com/palantir/go-githubapp/blob/develop/example/config.yml

Is viper a good solution for dealing with this?
https://github.com/spf13/viper

@jlewi
Copy link
Owner Author

jlewi commented Sep 9, 2023

The other advantage of using viper is that when we use hydros as a CLI the configuration could be stored in the home directory and people could configure specific settings once for themselves; e.g. the path of their GitHubAppKey and the appid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant