-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for dev takeover and testing new ManifestSync yamls #65
Comments
One might expect the following to work.
kind: RepoConfig
This doesn't work though because RepoConfig won't override the repositories referenced in ManifestSync. So they could end up pointing at Main which means the images that do get built will have the commit of the branch but the ManifestSync will look for the commit corresponding to main so it won't find the images and hydration won't succeed. This is a perfect use case for a kustomize function. hydros/pkg/gitops/repocontroller.go Line 157 in 071b01b
So we could apply any transformations in memory. |
#75 works pretty well for deploying a bunch of microservices. The current pain point would be that with #75 you have to rebuild all images on every commit which would be very expensive. I think a better approach would be
|
Per #65 we want to make it easy to use a RepoConfig and deploy from a branch * Add repo mappings to RepoConfig . This is a set of repo URLs to rewrite the source branches in manifest sync this allows the application to be deployed from a branch. * Also add a Pause option which can be used for a takeover. * Fix #75 when matching globs against paths in a tarball we need to strip any leading "/" in the path. Add a version command to hydros * Update goreleaser to start setting the version
A related problem is the developer flow when defining a new
We can't use a "takeover" because that will try to push any commits on your local branch to the sourceRepo listed in the |
With the addition of the Repo resource #59 we now support building a whole bunch of resources (Images, Manifests) that comprise an application.
One of the friction points right now is doing a takeover. Right now to do a dev takeover the usual pattern is to create a second manifestsync.yaml. That's kind of annoying.
An alternative would be to use kustomize functions to replace all the git references in a bunch of resources to point to a branch or even a local path.
One thing this doesn't solve is how do we selectively enable rebuilding certain images but not others?
The text was updated successfully, but these errors were encountered: