-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Music Videos with Extras
prebuilt preset
#806
Comments
Music Videos with Extras
prebuilt preset
Apologies if I missed anything in recent commits (I am currently updating my config/subs file to simplify it to the recent changes (ie I no longer needed to have my tag info as it is now present in the base preset). Seeing as you mention video titles here, one thing I noticed is that sites don't stick to a common naming convention. You have:
The first issue is easy to get around by using the subscription name. The second is more awkward as I don't want to have to add the titles every single time to fix the inconsistancies. Prior to adding my tag info, Jellyfin would lump all videos in the artist folder into one item, with the video selectable as if you were selecting the audio language to use on a movie. The second issue with them is a bit more involved. Based on the advanced TV example, I have come up with the following for Artist Name - Video Name style conventions. Is it worth supporting something similar to TV Show Only Recent in the examples and having something that extends the basic music video preset to add support for the different conventions?
|
Ironically I had this same debate with myself when writing these presets, here is my personal regex:
My conclusion is that there's no perfect regex. Even the one you have above isn't foolproof. This song for example has I know the titles won't look great in the player, but that's where custom configs and maybe some helper presets can come into play for enhancing the base prebuilt preset. Maybe we could call it |
As for specifying hard-coded titles in the above |
Totally agree with the hard-coded titles comment. |
is this part of the code yet? |
It is not |
Will use this feature for it: #859 |
Added in #808 |
Thank you, I'll take a look when I next update the subscriptions. I'm guessing from what I can see of the commit log that this doesn't include the regex feature for the artist - song titles mentioned above. I created two presets based on the above to extract the titles (one for artist - song, the other reversed for song - artist) and just add it to the relevant subsciptions that follow a supported scheme. |
Requires regex'ing override variables prior to any downloading/processing
Can be done today using multi-url
Or many overrides
Or as a list (but requires every-other to be a URL)
The text was updated successfully, but these errors were encountered: