Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open window and preset change issue #837

Open
Klaestrup opened this issue Jan 18, 2025 · 9 comments
Open

Open window and preset change issue #837

Klaestrup opened this issue Jan 18, 2025 · 9 comments
Labels
bug Something isn't working P1 Priority 1 Template not respected The issue template have not been respected. The maintainer doesn't have enough informations

Comments

@Klaestrup
Copy link

Klaestrup commented Jan 18, 2025

I have this issue, that if the window is open, the window detection feature closes the valve after 30 secs as expected. While the window was open, an automation was changing from Eco (20 deg.) to Comfort (22 deg.) mode. After I closed the window, the mode was Comfort as expected, but the temperature setpoint was not changed from 20 to 22 degrees. If I then manually changed to Eco and then back to Comfort again, the setpoint was changed fine - so it only happens if changing preset mode while window is open.
Besides this, everything seems to be working just fine! 👍👍

@jmcollin78 jmcollin78 added the Template not respected The issue template have not been respected. The maintainer doesn't have enough informations label Jan 18, 2025
@KipK
Copy link

KipK commented Jan 29, 2025

I have a similar problem, using over switch vtherms.

When windows are open vtherms goes to 7°, preset still positionned on Comfort.
After window is closed, Vtherms switch back to 18° instead of 19° ( aka T° of comfort mode )
Comfort is still displayed on UI but temperature is at 18.
I always have to switch back to 19° then.

Image

Image

on my example, I have booth thermostat_salon and thermostat_cuisine using the same windows group as they are on the same room.

Related logs:

2025-01-29 12:01:27.821 INFO (MainThread) [custom_components.versatile_thermostat.feature_window_manager] WindowManager-Thermostat Salon - Window is closed. Restoring hvac_mode 'None' if stopped by window detection or temperature 18.0
2025-01-29 12:01:27.821 DEBUG (MainThread) [custom_components.versatile_thermostat.thermostat_switch] VersatileThermostat-Thermostat Salon - Calling update_custom_attributes: {'is_on': True, 'hvac_action': <HVACAction.HEATING: 'heating'>, 'hvac_mode': <HVACMode.HEAT: 'heat'>, 'preset_mode': 'comfort', 'type': None, 'is_controlled_by_central_mode': True, 'last_central_mode': 'Heat only', 'frost_temp': 7.0, 'eco_temp': 17.5, 'boost_temp': 20.0, 'comfort_temp': 19.0, 'frost_away_temp': 7.0, 'eco_away_temp': 17.0, 'boost_away_temp': 19.0, 'comfort_away_temp': 18.0, 'target_temperature_step': 0.5, 'ext_current_temperature': 9.38, 'ac_mode': False, 'saved_preset_mode': 'comfort', 'saved_target_temp': 18.0, 'saved_hvac_mode': None, 'last_temperature_datetime': '2025-01-29T12:00:44.285951+01:00', 'last_ext_temperature_datetime': '2025-01-29T11:56:21.884615+01:00', 'minimal_activation_delay_sec': 60, 'total_energy': 617185.0, 'last_update_datetime': '2025-01-29T12:01:27.821091+01:00', 'timezone': 'Europe/Paris', 'temperature_unit': <UnitOfTemperature.CELSIUS: '°C'>, 'is_device_active': True, 'device_actives': ['switch.switch_rad_salon'], 'nb_device_actives': 1, 'ema_temp': 18.07, 'is_used_by_central_boiler': False, 'temperature_slope': 0.58, 'hvac_off_reason': None, 'max_on_percent': None, 'have_valve_regulation': False, 'last_change_time_from_vtherm': '2025-01-29T00:29:25.760354+01:00', 'presence_sensor_entity_id': 'input_boolean.presence', 'presence_state': 'on', 'is_presence_configured': True, 'power_sensor_entity_id': 'sensor.linky_puissance_inst_no_evse', 'max_power_sensor_entity_id': 'sensor.linky_pcoup_marge_evse', 'overpowering_state': 'off', 'is_power_configured': True, 'device_power': 1500.0, 'power_temp': 15.0, 'current_power': 3353.0, 'current_max_power': 9000.0, 'mean_cycle_power': 0.0, 'motion_sensor_entity_id': None, 'motion_state': 'unavailable', 'is_motion_configured': False, 'motion_delay_sec': 30, 'motion_off_delay_sec': 300, 'motion_preset': 'comfort', 'no_motion_preset': 'eco', 'window_state': 'off', 'window_auto_state': 'unavailable', 'window_action': 'window_frost_temp', 'is_window_bypass': False, 'window_sensor_entity_id': 'binary_sensor.ouverture_rdc', 'window_delay_sec': 30, 'window_off_delay_sec': 30, 'is_window_configured': True, 'is_window_auto_configured': False, 'window_auto_open_threshold': 3.0, 'window_auto_close_threshold': 0.0, 'window_auto_max_duration': 30, 'is_safety_configured': True, 'safety_state': 'off', 'safety_delay_min': 60, 'safety_min_on_percent': 0.1, 'safety_default_on_percent': 0.0, 'is_over_switch': True, 'is_inversed': False, 'keep_alive_sec': 0, 'underlying_entities': ['switch.switch_rad_salon'], 'on_percent': 0, 'power_percent': 0, 'on_time_sec': 0, 'off_time_sec': 600, 'cycle_min': 10, 'function': 'tpi', 'tpi_coef_int': 0.7, 'tpi_coef_ext': 0.05, 'calculated_on_percent': 0}
2025-01-29 12:01:27.821 DEBUG (MainThread) [custom_components.versatile_thermostat.feature_window_manager] WindowManager-Thermostat Cuisine - Window delay condition is satisfied
2025-01-29 12:01:27.821 DEBUG (MainThread) [custom_components.versatile_thermostat.feature_window_manager] WindowManager-Thermostat Cuisine - Window ByPass is : False
2025-01-29 12:01:27.821 INFO (MainThread) [custom_components.versatile_thermostat.feature_window_manager] WindowManager-Thermostat Cuisine - Window is closed. Restoring hvac_mode 'None' if stopped by window detection or temperature 18.0
2025-01-29 12:01:27.821 DEBUG (MainThread) [custom_components.versatile_thermostat.thermostat_switch] VersatileThermostat-Thermostat Cuisine - Calling update_custom_attributes: {'is_on': True, 'hvac_action': <HVACAction.HEATING: 'heating'>, 'hvac_mode': <HVACMode.HEAT: 'heat'>, 'preset_mode': 'comfort', 'type': None, 'is_controlled_by_central_mode': True, 'last_central_mode': 'Heat only', 'frost_temp': 7.0, 'eco_temp': 17.5, 'boost_temp': 20.0, 'comfort_temp': 19.0, 'frost_away_temp': 7.0, 'eco_away_temp': 17.0, 'boost_away_temp': 19.0, 'comfort_away_temp': 18.0, 'target_temperature_step': 0.5, 'ext_current_temperature': 9.38, 'ac_mode': False, 'saved_preset_mode': 'comfort', 'saved_target_temp': 18.0, 'saved_hvac_mode': None, 'last_temperature_datetime': '2025-01-29T12:00:35.440228+01:00', 'last_ext_temperature_datetime': '2025-01-29T11:56:21.884615+01:00', 'minimal_activation_delay_sec': 60, 'total_energy': 713147.5, 'last_update_datetime': '2025-01-29T12:01:27.821478+01:00', 'timezone': 'Europe/Paris', 'temperature_unit': <UnitOfTemperature.CELSIUS: '°C'>, 'is_device_active': True, 'device_actives': ['switch.switch_rad_cuisine'], 'nb_device_actives': 1, 'ema_temp': 18.03, 'is_used_by_central_boiler': False, 'temperature_slope': 0.27, 'hvac_off_reason': None, 'max_on_percent': None, 'have_valve_regulation': False, 'last_change_time_from_vtherm': '2025-01-29T10:52:17.767948+01:00', 'presence_sensor_entity_id': 'input_boolean.presence', 'presence_state': 'on', 'is_presence_configured': True, 'power_sensor_entity_id': 'sensor.linky_puissance_inst_no_evse', 'max_power_sensor_entity_id': 'sensor.linky_pcoup_marge_evse', 'overpowering_state': 'off', 'is_power_configured': True, 'device_power': 1500.0, 'power_temp': 15.0, 'current_power': 3353.0, 'current_max_power': 9000.0, 'mean_cycle_power': 0.0, 'motion_sensor_entity_id': None, 'motion_state': 'unavailable', 'is_motion_configured': False, 'motion_delay_sec': 30, 'motion_off_delay_sec': 300, 'motion_preset': 'comfort', 'no_motion_preset': 'eco', 'window_state': 'off', 'window_auto_state': 'unavailable', 'window_action': 'window_frost_temp', 'is_window_bypass': False, 'window_sensor_entity_id': 'binary_sensor.ouverture_rdc', 'window_delay_sec': 30, 'window_off_delay_sec': 30, 'is_window_configured': True, 'is_window_auto_configured': False, 'window_auto_open_threshold': 3.0, 'window_auto_close_threshold': 0.0, 'window_auto_max_duration': 30, 'is_safety_configured': True, 'safety_state': 'off', 'safety_delay_min': 60, 'safety_min_on_percent': 0.1, 'safety_default_on_percent': 0.0, 'is_over_switch': True, 'is_inversed': False, 'keep_alive_sec': 0, 'underlying_entities': ['switch.switch_rad_cuisine'], 'on_percent': 0, 'power_percent': 0, 'on_time_sec': 0, 'off_time_sec': 600, 'cycle_min': 10, 'function': 'tpi', 'tpi_coef_int': 0.7, 'tpi_coef_ext': 0.05, 'calculated_on_percent': 0}

18° is Comfort in away mode for those vtherms. Or it's the temp I set with the scheduler during the night between 1am to 6am.

It's also the main temperature for other rooms vtherms.

@jmcollin78
Copy link
Owner

Hello,

Once again, I cannot help you, if you don't follow the issue template: which release ? What are the attributes ? How window feature is configured ?

That is the meaning of the "Template not respected" Label.

@KipK

This comment has been minimized.

@Klaestrup
Copy link
Author

Klaestrup commented Jan 29, 2025 via email

@KipK

This comment has been minimized.

@KipK

This comment has been minimized.

@jmcollin78
Copy link
Owner

Hello @KipK ,

Your window is not detected as open: window_state: off so it is not wrong that the saved_target_temp is set to 18 or whatever. It is just not relevant.

Relevant logs are the same as posted #837 (comment)

I will keep this new issue but please 🙏 🙏 don't post same issue on multiple. It is already very difficult to answer all request and this gives me more work to understand what is relevant with what.

@KipK
Copy link

KipK commented Feb 1, 2025

I will keep this new issue but please 🙏 🙏 don't post same issue on multiple.

I haven't. This was just a link to this thread 😉

As you can see on the graph screenshots, the window is well detected as open. Look at the first field in grey and yellow. Also the window icon appear on UI when opened. You can also see the vtherm has switched to 7° whe open

The other issue is a separated one that's why I've created a new one to not bring confusion here.
But if you prefer I can post booth those issues on my other thread? U tell me

edit: here is a little video of the whole process. Window is opened at beginning, few secs after vtherm switch to window open mode, then Window is closed , then vtherm switch back to normal mode, but temp is at 18 and comfort is still set.
( also can see the other issue from the other thread , heater are still heating while opened, but that's another thread ) .

vtherm.mp4

edit: my previous log missed the opening state, here are some logs with everything:

https://pastebin.com/0HAEA1HQ

@KipK
Copy link

KipK commented Feb 1, 2025

I think I've found something interesting.

Looking at the attributes, while vtherm is set at comfort 19°.

Attributes:

  • temperature: 19
  • saved_target_temp: 18
  • preset_mode: comfort

I then set it to 19.5:

  • temperature: 19.5
  • saved_target_temp: 18
  • preset_mode: none

I then set back to 19°:

  • temperature: 19
  • saved_target_temp: 19
  • preset_mode: none

Looks like the saved_target_temp is not always updated

Edit: @jmcollin78 I don't know if it's a dirty fix or not, but calling self._vtherm.save_target_temp() line 283 of feature_window_manager.py fix the issue:

else:
            _LOGGER.info(
                "%s - Window is open. Apply window action %s", self, self._window_action
            )
            #trying to fix  #837
            self._vtherm.save_target_temp()

            if self._window_action == CONF_WINDOW_TURN_OFF and not self._vtherm.is_on:
                _LOGGER.debug(
                    "%s is already off. Forget turning off VTherm due to window detection"
                )

@jmcollin78 jmcollin78 added bug Something isn't working P1 Priority 1 labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Priority 1 Template not respected The issue template have not been respected. The maintainer doesn't have enough informations
Projects
None yet
Development

No branches or pull requests

3 participants