Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings in generated fs-analysis-input.xml is always empty #91

Open
milbrandt opened this issue Mar 15, 2020 · 3 comments
Open

Settings in generated fs-analysis-input.xml is always empty #91

milbrandt opened this issue Mar 15, 2020 · 3 comments

Comments

@milbrandt
Copy link
Collaborator

see method appendSettings in FSharpSensor.java

@jmecosta Do you remember if this section was formerly used? Or is it a leftover from the starting when copying from another analyzer?

@jmecosta
Copy link
Owner

jmecosta commented Mar 15, 2020 via email

@milbrandt
Copy link
Collaborator Author

seems like it is coming from https://github.com/SonarSource/sonar-dotnet/blob/master/sonaranalyzer-dotnet/src/SonarAnalyzer.Common/Rules/Utilities/UtilityAnalyzerBase.cs

The key sonar.cs.ignoreHeaderComments in the XmlHelper.fs is a setting in SonarQube admin UI for C# language scanner.

Thanks, we'll have to see if any value will be configurable globally, like numIndentationSpaces or IgnoreFiles - or even allow users to define additional hint rules

@jmecosta
Copy link
Owner

the optimal would be to have all rule configuration defined in the profiles! but its a bit hard to get this synchronized from both sides! anyway if that materializes then its all added bonus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants