Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading/writing strings within plugins as ascii discards information #10

Open
benjaminwinger opened this issue Mar 5, 2021 · 1 comment

Comments

@benjaminwinger
Copy link

Data should be treated as either cp1250, cp1251 or cp1252, and ideally this should be determined based on the encoding in openmw.cfg.

E.g. any plugins with non-ascii characters in their filename will cause an error when openmw loads OMWLLF.omwaddon, as no matching master file would be found.

This could also affect the contents of the levelled lists, as that information could also contain non-ascii data.

https://www.nexusmods.com/morrowind/mods/45198 is an example of a mod which causes this problem, as the plugin name is Wait and Sleep for OpenMW ± Standard Version.omwaddon.

@benjaminwinger benjaminwinger changed the title Reading/writing plugins as ascii discards information Reading/writing strings within plugins as ascii discards information Mar 5, 2021
@benjaminwinger
Copy link
Author

Okay, I realised that omwllf only adds the masters of plugins that it uses, not the plugins themselves, so it won't fail directly on the example I gave above, but the problem in general still stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant