Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array.includes helper? #86

Open
mehulkar opened this issue Aug 20, 2018 · 3 comments · May be fixed by #111
Open

Array.includes helper? #86

mehulkar opened this issue Aug 20, 2018 · 3 comments · May be fixed by #111

Comments

@mehulkar
Copy link

mehulkar commented Aug 20, 2018 •
edited
Loading

It would be super useful to have a {{includes array item}} helper that does Array.prototype.includes. Would this helper be appropriate for this addon?
@Oreoz
Copy link

Oreoz commented Aug 23, 2018

@mehulkar Just so you know, ember-composable-helpers has this helper. https://github.com/DockYard/ember-composable-helpers#contains

That doesn't mean it's not appropriate for ember-truth-helpers, I'll let the devs decide for themselves. :)

@mehulkar
Copy link
Author

mehulkar commented Aug 24, 2018 via email

@mum-never-proud mum-never-proud linked a pull request Mar 28, 2020 that will close this issue
Open
@mum-never-proud
Copy link

whooops! looks like there's some problem with Travis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for array includes mum-never-proud/ember-truth-helpers
3 participants
@mehulkar @Oreoz @mum-never-proud