Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skan should support float32 images #238

Open
jni opened this issue Dec 13, 2024 · 0 comments
Open

skan should support float32 images #238

jni opened this issue Dec 13, 2024 · 0 comments

Comments

@jni
Copy link
Owner

jni commented Dec 13, 2024

In #234 and #235, @ns-rse noticed that passing float32 images doesn't work in newer versions of skan (which pass the image unmodified rather than a float64 copy. That's because the numba jitclass declaration has an array of fixed dtype of float64[:]:

('node_properties', numba.float64[:]),

so passing float32 data to it causes an error. But! It would be good to be able to support float32 data, not least because it uses half the RAM, for limited loss in precision. So we should figure out a way to do that, maybe switching out two classes, NBGraph and NBGraph32, for example, depending on the input data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant