Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent behavior for code actions edits and commands #520

Open
ruricolist opened this issue Aug 6, 2020 · 2 comments
Open

Consistent behavior for code actions edits and commands #520

ruricolist opened this issue Aug 6, 2020 · 2 comments

Comments

@ruricolist
Copy link
Contributor

Currently, if I call eglot-code-actions and the server replies with edits, those edits are replied automatically. But if the server replies with commands instead of edits then (unless I set eglot-confirm-server-initiated-edits) I have to respond to a y/n prompt for the edits from that command to be applied. I think the behavior for actions should be consistent regardless of whether the server returns edits or commands.
@ruricolist
Copy link
Contributor Author

On further thought I'm not actually sure this is possible since the reply to workspace/executeCommand is asynchronous but it would be nice.

@skangas
Copy link
Collaborator

skangas commented Jan 13, 2022

Do you have a minimal test case that I could use to try to reproduce this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skangas @ruricolist