Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG call_queue size is not updated on resize #396

Open
tomMoral opened this issue Apr 14, 2023 · 1 comment
Open

BUG call_queue size is not updated on resize #396

tomMoral opened this issue Apr 14, 2023 · 1 comment

Comments

@tomMoral
Copy link
Collaborator

When resizing the reusable_executor, the call_queue is not resized.
It has a size 2 * n_workers + 1 originally so if the executor is enlarged a lot, this can cause sub-optimal performances as some workers might starve.

We might want to consider if we can resize the call_queue (probably hard as the size is defined with a BoundedSemaphore and it is hard to change it in all workers) or find an heuristic that works well.

@ogrisel
Copy link
Collaborator

ogrisel commented Apr 14, 2023

This problem is the cause of #397 (slow shutdown when the call queue size is much slower than the max_workers used to resize the pool.

A partial mitigation is implemented in #399 but we should still fix the root cause to avoid starving workers after a large resize.

@ogrisel ogrisel changed the title BUG call_queue size si not change on resize BUG call_queue size is not updated on resize Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants