Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luis feedback #17

Open
joelamouche opened this issue Sep 30, 2020 · 0 comments
Open

Luis feedback #17

joelamouche opened this issue Sep 30, 2020 · 0 comments

Comments

@joelamouche
Copy link
Owner

joelamouche commented Sep 30, 2020

You will have to account for the fact the the User should input the ETH amount they want to deposit into Maker.
You should also verify if the user already has a DSA deployed and then not deploy one if that is the case.
You should also verify if the User has already set GelatoCore as auth on DSA and only cast a spell to do so, if the user hasnt done so already.
As a final part of the MakerDAI->CDAI spell I would also add another Action. Namely to Transfer the CDAI out from the DSA into the User wallet.
So that we don't have any CDAI stuck in our DSA.
Also you need to have buttons to withdraw any remaining ETH from Gelato via your DSA and back to the User's wallet.
Also any remaining ETH in your DSA should have a withdraw button.
You can combine both transfers into one by using DSA spells
check out this code for how to withdraw stuff from the DSA: https://github.com/gelatodigital/gelato-instadapp/blob/7295ad39fe155c1ae00bdd752d443fa167fa2d37/test/0_setup-DSA-Gelato.test.js#L140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant