Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 routes are named oauth.callback #288

Closed
chris-sev opened this issue Sep 13, 2023 · 4 comments
Closed

2 routes are named oauth.callback #288

chris-sev opened this issue Sep 13, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@chris-sev
Copy link

chris-sev commented Sep 13, 2023

Describe the bug
I'm unable to run php artisan route:cache because there are 2 routes with the name oauth.callback

I believe it happened in this commit yesterday:

https://github.com/joelbutcher/socialstream/blob/4.x/routes/socialstream.php#L13-L14

Both the Route::get and Route::post are named oauth.callback

To Reproduce
Steps to reproduce the behavior:

  1. Run php artisan route:cache

Expected behavior
Caching works

Screenshots
CleanShot 2023-09-13 at 07 12 12@2x

Environment context

  • Socialstream version: 4.4.3
  • Jetstream stack: Inertia / Livewire
  • Laravel version: 10
  • PHP version: 8.2
@chris-sev chris-sev added the bug Something isn't working label Sep 13, 2023
@chris-sev chris-sev changed the title [bug] 2 routes are named oauth.callback Sep 13, 2023
@joelbutcher
Copy link
Owner

Thanks! I've patched with v4.4.4

@neopheus
Copy link

neopheus commented Nov 6, 2023

Hi @joelbutcher,

After updating to Socialstream v5.2, the php artisan route:cache still fails due to duplicate route names for oauth.callback.

Environment:

Socialstream v5.2
Laravel v10
PHP v8.2

@joelbutcher
Copy link
Owner

@neopheus can you test the changes made in this PR to see if this resolves the issue for you?

@neopheus
Copy link

neopheus commented Nov 8, 2023

Yes
You can validate the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants