Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of ggplot2 #577

Closed
spholmes opened this issue Feb 7, 2016 · 3 comments
Closed

New version of ggplot2 #577

spholmes opened this issue Feb 7, 2016 · 3 comments

Comments

@spholmes
Copy link
Contributor

spholmes commented Feb 7, 2016

library(phyloseq)
Warning messages:
1: replacing previous import by ‘ggplot2::Position’ when loading ‘phyloseq’
2: replacing previous import by ‘scales::alpha’ when loading ‘phyloseq’

This is the same error as noticed and responded to by Hadley here:
tidyverse/ggplot2#1335

who says
``Package developers need to fix those warnings, by being more selective with imports (i.e. don't import all of scales, just import the functions that you need)''

@colinbrislawn
Copy link

Thanks for posting this! Looks like this is tripping up a PR of mine (#575)

@joey711
Copy link
Owner

joey711 commented Feb 8, 2016

Thanks, Susan @spholmes I'll try and get this squared away soon. I need to push a few other updates into the current devel branch so its in the next release (including the jump to biomformat, which will go out in the next release...)

@joey711
Copy link
Owner

joey711 commented Mar 20, 2016

scales::alpha is resolved. ggplot2::Position is not, but it is unclear what package dependency is causing the problem. The next BioC update may have this solved. I will close for now and re-open if I get feedback from BioC. The proactive alternative is to explicitly import every ggplot2 exported object that is used in phyloseq... This would be a rather large amount of effort, and seemingly in the use case for which full package import is intended.

@joey711 joey711 closed this as completed Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants