Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts - occultations not rendered correctly. #30

Open
johanley opened this issue Mar 25, 2017 · 0 comments
Open

Charts - occultations not rendered correctly. #30

johanley opened this issue Mar 25, 2017 · 0 comments
Labels
bug

Comments

@johanley
Copy link
Owner

johanley commented Mar 25, 2017 •
edited
Loading

When an occultation is shown in a chart, by following a link from the main page, the rendering is off. The star is not close enough to the Moon's limb. It's off by ~20-40 minutes of time.

I checked the raw calc in ephem.js for the core calc of topocentric positions, and it seems ok (to within about 1 arcmin). The function EPH.apply_parallax_to_αδ(eph, wh) also seems ok.

So the bug is likely elsewhere. Size of the moon? Position of the star? The calc in code.js for the changes to ra, decl due to parallax?
@johanley johanley added the bug label Mar 25, 2017
@johanley johanley changed the title Charts - occultations not appearing at the right time. Charts - occultations not rendered correctly on charts. Mar 25, 2017
@johanley johanley changed the title Charts - occultations not rendered correctly on charts. Charts - occultations not rendered correctly. Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanley