Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackaton #70

Open
vedin-klovo opened this issue Jun 5, 2022 · 6 comments
Open

Hackaton #70

vedin-klovo opened this issue Jun 5, 2022 · 6 comments

Comments

@vedin-klovo
Copy link

Hi Johannes,

I implemented this algorithm for Carla a few years and would like to help with future development. Couldn't find you email so I created this issue. You can email me at [email protected] (personal) or [email protected] (university).

Best regards,
Vedin

@johannes-graeter
Copy link
Owner

Hi vedin,

this is awesome!!! Thanks for being the first to reply to my call for hackathon :).
Lets do this! Would love to just sit down for a couple of hours and do some paired coding, corresponding to the tasks i mentioned in the readme.
For the timing however i will need to push the date back a little. I am at the moment renovating my apartment and then on holidays and moving in. So how about we start in july? If your fingers tickle you can also start by yourself. Whats your skill set and field of expertise?

Thanks and all the best johannes

@vedin-klovo
Copy link
Author

vedin-klovo commented Jun 6, 2022 via email

@johannes-graeter
Copy link
Owner

Awesome!

  1. When you do some embedded you problem know your way around plain c as well? I actually wanted to have a plain c interface for the library for a long time now in order to interface with python or rust. I tried to do it with boost python and c++ but found that rather annoying.

  2. When i did this library i was purely working in ros, but it turned out to be a mistake to only interface through ros with f e. Kitti. It could be a good first task just create an executable form the library that runs it on kitti without ros.

Gladly I would have a meeting of an hour with you or so to discuss that and a working plan.
How does that sound?

Best

@vedin-klovo
Copy link
Author

vedin-klovo commented Jun 6, 2022 via email

@YoshuaNava
Copy link

YoshuaNava commented Jun 13, 2022

Hi,

I think the work from this repo and related papers is excellent. I unfortunately can't engage in open source projects at the moment, but wish you the best in this sprint.

Something I would suggest based on personal experience is to split ROS and core algorithms, but not in a way in which observability is completely lost, e.g. removing publishers and logging from places where they help to retrieve useful feedback for algorithm development.

I would propose a candidate design pattern for implementing ROS nodes: https://refactoring.guru/design-patterns/template-method

With this, you could have a parent class Limo, and then children classes LimoRos, LimoRos2, etc, which implement all the infrastructure to visualize data as private methods. Also, you could preserve the threading model that you need for Limo, while enabling observability in the interface.

Hope this helps.

Best regards,
Yoshua Nava

@johannes-graeter
Copy link
Owner

This is great advice @YoshuaNava thx, will definitely consider that!
@vedin-klovo sorry for not replying, how about we have a call on thursday (1pm would be cool so that its in my lunchbreak)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants