Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work plan for mono_lidar refactor #76

Open
1 of 3 tasks
johannes-graeter opened this issue Aug 19, 2022 · 0 comments
Open
1 of 3 tasks

Work plan for mono_lidar refactor #76

johannes-graeter opened this issue Aug 19, 2022 · 0 comments

Comments

@johannes-graeter
Copy link
Owner

johannes-graeter commented Aug 19, 2022

steps for preparation

  • Write a main that reporduces complete process with kitti data

    • make reader for kitti data
    • add limo behaviour to that main (params can be read by ros)
    • evaluate on kitti to repodruce results
  • Write more unit tests for expected current behaviour

  • Identify in which mode monolidar ist currently launched

things to make better

  • One coding style
  • No NULL
  • Remove unused options
  • Clear input and output
  • Output as return
  • Error state through return
  • Noexcept
  • Some double work could be reduced

open questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant