Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing legacy "View Engine" libraries: - angular2-promise-buttons [es2015/esm2015] #91

Open
ashikjs opened this issue Nov 8, 2022 · 10 comments

Comments

@ashikjs
Copy link

ashikjs commented Nov 8, 2022

: Angular 14+ with Iv rendering give warning

Processing legacy "View Engine" libraries:

  • angular2-promise-buttons [es2015/esm2015] (git+ssh://[email protected]/johannesjo/angular2-promise-buttons.git)
  • Encourage the library authors to publish an Ivy distribution.
@LeahPike
Copy link

I'm using Angular 17 and unable to build, is there expected to be an update?

error NG6002: 'Angular2PromiseButtonModule' does not appear to be an NgModule class.
This likely means that the library (angular2-promise-buttons) which declares Angular2PromiseButtonModule is not
compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

@danilobassi8
Copy link

danilobassi8 commented Nov 28, 2023

I'm using Angular 17 and unable to build, is there expected to be an update?

error NG6002: 'Angular2PromiseButtonModule' does not appear to be an NgModule class.
This likely means that the library (angular2-promise-buttons) which declares Angular2PromiseButtonModule is not
compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

AFAIK, this library already supports ivy compilation, but the owner didn't deploy a new version 😞

@ashikjs
Copy link
Author

ashikjs commented Nov 28, 2023

@danilobassi8 should we make a replica of this repo and published a new library as extend version and continue improvement.

@danilobassi8
Copy link

@ashikjs the author of this lib @johannesjo is an active GitHub user. Should be easy for him to deploy a new version of this package with latest changes. Maybe he's been busy on other projects.
It'd be a pity to let this project die just to avoid clicking the "deploy" button.
But as this is stopping us, (and probably a lot of people) from migrating from Angular 15 to 16, forks are going to be created.

@ashikjs
Copy link
Author

ashikjs commented Nov 29, 2023

@danilobassi8 Maybe auther active in other project but he did not release any new version form last 2 years so i don't see any luck.

@johannesjo
Copy link
Owner

johannesjo commented Nov 30, 2023

Hey guys. The project isn't a priority any more for me, so I likely won't contribute any code any time soon, but I gladly check any PRs. I can also give access to someone else, if needed.

@danilobassi8
Copy link

@johannesjo we understand that and we appreciate your affords, but in this case the only thing we need is you to deploy the last changes on the master branch to npm!

This PR #99 that @andrezz-b did is all we need. But you are the only one that can deploy this to npm.
The code here on github is unsynced with the one on npm! the last version is from 2 years ago.

If you deploy a new npm version this issue should be closed!

@johannesjo
Copy link
Owner

johannesjo commented Dec 1, 2023

@danilobassi8 a new major release is out (untested).

Sorry for the delay everyone!!

@worthy7
Copy link

worthy7 commented Dec 12, 2023

Is it working for anyone? My angular 17 is still complaining that version 6.0.0 is not an Ivy compilation....

@ashikjs
Copy link
Author

ashikjs commented Dec 12, 2023

Maybe we need new fixed for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants