Fix compilation with Xcode >= 16.0

[jkrukowski]

I came across the issue when my package (which indirectly depends on Jinja) was built on swiftpackageindex.com
The build resulted in error, more info here:
https://swiftpackageindex.com/builds/EF6D0DF9-542C-47AE-9D1A-D16C8790BF71

Looks like the easiest fix is to provide a separate Package.swift for Swift 6.0. To repro it locally you can try to build it from command line using:

env DEVELOPER_DIR=/Applications/Xcode-16.1.0.app xcrun xcodebuild -skipMacroValidation -skipPackagePluginValidation build -scheme Jinja -destination platform=macOS,arch=arm64 OTHER_SWIFT_FLAGS=-strict-concurrency=complete

Without [email protected] this should give an error, with it, it should build.

[jkrukowski]

Same happens in swift-transformers repo https://swiftpackageindex.com/builds/F6095453-30D2-4175-8FBF-E28D9AD440FE it fails to compile because seems like swift 6 has BareSlashRegexLiterals enabled by default https://github.com/swiftlang/swift-evolution/blob/main/proposals/0354-regex-literals.md#source-compatibility

[jkrukowski]

Another solution would be to wrap regex literals in #/.../#, let me know how you want to proceed @maiqingqiang

[johnmai-dev]

Thank you, I'll review it tonight.

[johnmai-dev]

Adding [email protected] only solved the build issue, it didn't really make Jinja support Swift 6, right?

[jkrukowski]

Adding [email protected] only solved the build issue, it didn't really make Jinja support Swift 6, right?

yes, that's correct, it makes Jinja compile with >= Xcode 16.0, I'll update the PR title

[johnmai-dev]

Another solution would be to wrap regex literals in #/.../#, let me know how you want to proceed @maiqingqiang

Perhaps we could do it this way?
https://github.com/swiftlang/swift-evolution/blob/main/proposals/0362-piecemeal-future-features.md

#if compiler(>=5.7)
  #if hasFeature(BareSlashRegexLiterals)
  let regex = /.../
  #else
  let regex = #/.../#
  #endif
#else
let regex = try NSRegularExpression(pattern: "...")
#endif

[jkrukowski]

Another solution would be to wrap regex literals in #/.../#, let me know how you want to proceed @maiqingqiang

Perhaps we could do it this way? https://github.com/swiftlang/swift-evolution/blob/main/proposals/0362-piecemeal-future-features.md

#if compiler(>=5.7)
  #if hasFeature(BareSlashRegexLiterals)
  let regex = /.../
  #else
  let regex = #/.../#
  #endif
#else
let regex = try NSRegularExpression(pattern: "...")
#endif

Looks good, however:

• this might be a bit excessive because this package will not work with Swift < 5.8, that's the version which is specified in Package.swift
• why don't we wrap every regex literal between # so for example this line becomes .replacing(#/{##}/#, with: "")wdyt? This way we don't need additional package.swift for swift 6 only

[johnmai-dev]

Another solution would be to wrap regex literals in #/.../#, let me know how you want to proceed @maiqingqiang

Perhaps we could do it this way? https://github.com/swiftlang/swift-evolution/blob/main/proposals/0362-piecemeal-future-features.md

#if compiler(>=5.7)
  #if hasFeature(BareSlashRegexLiterals)
  let regex = /.../
  #else
  let regex = #/.../#
  #endif
#else
let regex = try NSRegularExpression(pattern: "...")
#endif

Looks good, however:

• this might be a bit excessive because this package will not work with Swift < 5.8, that's the version which is specified in Package.swift
• why don't we wrap every regex literal between # so for example this line becomes .replacing(#/{##}/#, with: "")wdyt? This way we don't need additional package.swift for swift 6 only

Sure, you can directly use .replacing(#/{##}/#, with: "").

[johnmai-dev]

Thanks for the fix!