Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] Remove protocol and server name from photo.url #31

Open
tetraf opened this issue May 20, 2013 · 2 comments · May be fixed by #41
Open

[patch] Remove protocol and server name from photo.url #31

tetraf opened this issue May 20, 2013 · 2 comments · May be fixed by #41

Comments

@tetraf
Copy link

tetraf commented May 20, 2013

This causes issues if protocol is https, port is mapped or server is accessed with an other name.

Patch to use with git apply: https://gist.github.com/tetraf/5611901
@alexandre-mbm
Copy link

Are you sure you do not enter a fault? Did you check if that "url" is not parsed further, for example? I might be turning your patch in a pull request, to facilitate to @johnmckerrell. I want to solve very simple issues like this can be.

@tetraf
Copy link
Author

tetraf commented Mar 6, 2014

It works for me, and I didn't see other operation on this string.

alexandre-mbm added a commit to alexandre-mbm/OpenStreetView that referenced this issue Mar 13, 2014
@alexandre-mbm
Remove protocol and server name from photo.url.
4e87ef2 
Applying @tetraf's patch. Closes johnmckerrell#31.
@alexandre-mbm alexandre-mbm linked a pull request Mar 13, 2014 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Applies the @tetraf's patch alexandre-mbm/OpenStreetView
2 participants
@alexandre-mbm @tetraf