-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable / Beta branches #2
Comments
Hi. Thanks for trying Flock. It's great that you were able to take it end-to-end. As you alluded to, Flock right now is literally a copy of Flutter master, so that's expected. We absolutely want to mirror We haven't decided exactly what mechanism we want to use to integrate our own changes. We'll want to find the option that looks like it will create the least amount of maintenance work as Flutter continues to change under Flock.
Not yet, but feel free to file issues like this for anything that comes up. We'll assemble some issue templates at some point.
Yes, definitely. Probably everything that isn't related to FVM or branch selection will be a Flutter bug at this point. So those issues should all be logged against Flutter. |
We just filed flutter/flutter#157827 after painstakingly recompiling a ton of different master commits until we identified the culprit. The amount of bandwidth and time invested is insane. And of course, it seems to us, that it is caused by an engine issue. As a reference, we would label this as a p0 as it affects iOS scrolling which is one of the most essential mobile interactions, but lets see how it turns out. |
on the same boat. Using some packages that doesnt support the Master channel of flutter yet and need to build on stable. Would really want to tryout flock. The current "stable" branch here to bad gives a version of 0.0.0-unknown |
Hi, I wanted to drop this Discussion link here in case either of you have input: #20 |
We were just able to switch to the
Flock
master
channel withfvm
and everything worked great!This includes all the tests and the release scripts which were using
fvm
andfastlane
.We were able to publish a new TestFlight release built with
Flock
and it got approved onApp Store Connect
without issues.However, our external testers are reporting some loss in scrolling smoothness, specifically on an older iPhone Mini.
It doesn't seem to be related to
Flock
as we did another TestFlight release with the originalFlutter
master
channel and we were able to reproduce the same loss in scrolling smoothness.In our experience, the
Flutter
team has frequent performance regressions on theirmaster
channel, which is why we have been forced to stay on thestable
channel thus far.We have a few questions :
Flock
going to mirror thestable
andbeta
branches as well?Flock
which will be lacking fromFlutter
, will there be something likestable-cp
(cherry-picks) branch onFlock
which will provide all the benefits of thestable
branch fromFlutter
+ the most impactful fixes fromFlock
?Flock
?Flutter
master
channel, should we file it in theFlutter
repo or here?Thank you and great work so far!
The text was updated successfully, but these errors were encountered: