Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order talks consistently by track per time slot #869

Open
iansltx opened this issue Oct 23, 2019 · 1 comment
Open

Order talks consistently by track per time slot #869

iansltx opened this issue Oct 23, 2019 · 1 comment
Labels
help wanted Stuff that we would love contributions for Improvement user-attendee Feature for attendees

Comments

@iansltx
Copy link
Contributor

iansltx commented Oct 23, 2019

This is probably easier to do as an API change (might move the issue over there if I start working on it and find that this is the case) but when viewing talks in the list view on e.g. a four-track conference, for two slots where all four tracks are occupied, the third talk in the list for each slot should correspond to the same track, vs. relying on talk insertion order (which gets extra messy for subbing in talks later).

Eventually we'll want to allow specified order for tracks. But relying on track insertion order (AKA PK) should be sufficient for now, as tracks take less elbow grease to create than talks.

@iansltx iansltx added help wanted Stuff that we would love contributions for Improvement user-attendee Feature for attendees labels Oct 23, 2019
@iansltx
Copy link
Contributor Author

iansltx commented Oct 23, 2019

Looks like this will be slightly easier to perform in this repo as a quick fix; there's an N+1 going on in the talk list for grabbing tracks so it's not really any more efficient to sort talks by track (which is a 1:M somehow) API-side than client-side.

Just checked the database and we actually only ever have one track associated per talk, though some talks have a track ID of 0 multiple times. So we could actually pull the track ID into the talk model as an ?int, cleaning up both existing data and querying in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Stuff that we would love contributions for Improvement user-attendee Feature for attendees
Projects
None yet
Development

No branches or pull requests

1 participant