Feature/symfony34 #903
Open
Feature/symfony34 #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zghosts
force-pushed
the
feature/symfony34
branch
3 times, most recently
from
a306b6c
to
8bdb5a5
Compare
|
This looks like a stale PR. I would recommend closing it and revisit the topic at a later time (perhaps convert to an issue). |
|
@zghosts If you can re-roll this after deps are updated in the other outstanding PR, I'll at the very least do a code review on the changes soon, probably Monday evening (your time) of next week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the symfony components to version 3.4 and updates all forms and middlewares accordingly.
As test coverage is not 100% this will probably require some manual testing by the reviewer, I've tested all forms, but could use an extra pair of eyes