Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgur support and Amazon Music Support #83

Open
Cxsmo-ai opened this issue Apr 12, 2023 · 7 comments
Open

Add imgur support and Amazon Music Support #83

Cxsmo-ai opened this issue Apr 12, 2023 · 7 comments
Labels
duplicate This issue or pull request already exists

Comments

@Cxsmo-ai
Copy link

Cxsmo-ai commented Apr 12, 2023

add imgur support so that you can make cover arts work even if the music player doesn't send them like this does using imgur api key https://github.com/Radiicall/jellyfin-rpc and also add amazon music support like this has https://github.com/cytsai1008/bezos-presence but improve artist and song name detection

@Cxsmo-ai Cxsmo-ai changed the title add imgur support so that you can make cover arts work even if the music player doesn't send them like this does using imgur api key https://github.com/Radiicall/jellyfin-rpc add imgur support so that you can make cover arts work even if the music player doesn't send them like this does using imgur api key https://github.com/Radiicall/jellyfin-rpc and also add amazon music support like this has https://github.com/cytsai1008/bezos-presence Apr 12, 2023
@Cxsmo-ai Cxsmo-ai changed the title add imgur support so that you can make cover arts work even if the music player doesn't send them like this does using imgur api key https://github.com/Radiicall/jellyfin-rpc and also add amazon music support like this has https://github.com/cytsai1008/bezos-presence add imgur support so that you can make cover arts work even if the music player doesn't send them like this does using imgur api key https://github.com/Radiicall/jellyfin-rpc and also add amazon music support like this has https://github.com/cytsai1008/bezos-presence but improve artist and song name detection Apr 12, 2023
@jojo2357 jojo2357 changed the title add imgur support so that you can make cover arts work even if the music player doesn't send them like this does using imgur api key https://github.com/Radiicall/jellyfin-rpc and also add amazon music support like this has https://github.com/cytsai1008/bezos-presence but improve artist and song name detection Add imgur support and Amazon Music Support Apr 12, 2023
@jojo2357
Copy link
Owner

There is currently "remote arts" which attempts what imagur does. I do not have any plans to integrate that at this time.

Amazon music was looked into, but seeing how your referenced link uses the same api as I do, there is nothing I can do better than it, and amazon music was unreliable and hard to test. is it better now?

@Cxsmo-ai
Copy link
Author

but is there a way to get amazon music rpc working the way you currently have it but with imgur api image fetching.

@jojo2357
Copy link
Owner

What do you mean by "imgur api image fetching"? Is that different than what I already have, and if so, please elaborate.

@Cxsmo-ai
Copy link
Author

you can use the imgur api and imgur api key to have the cover art be pulled from imgur like this does https://github.com/Radiicall/jellyfin-rpc

@Cxsmo-ai
Copy link
Author

and also this has better song detection then your rpc for amazon music https://github.com/cytsai1008/bezos-presence

@jojo2357
Copy link
Owner

I just realized that you are the author of #72 as well. please revisit it as nothing has changed. maybe amazon music has changed, but there is nothing more I will do on that front.

As for imgur: please explain to me in words what you would like. Stop sending me url's and explain what MDRP needs to do that it can't already do.

@Smaltin
Copy link
Collaborator

Smaltin commented Apr 13, 2023

you can use the imgur api and imgur api key to have the cover art be pulled from imgur like this does https://github.com/Radiicall/jellyfin-rpc

The imgur part in the Jellyfin RPC is simply to host the images of the movies externally instead of setting up port forwarding. The current MDRP fetches the images from an API and caches the URL to that file, making Imgur unnecessary.

add amazon music support like this has https://github.com/cytsai1008/bezos-presence but improve artist and song name detection

For Amazon Music, in DiscordPresenceConfig.ini add amazon music=true=808571949227049000 at the top of the page. As mentioned previously in #72 there's not much more we can do

@jojo2357 jojo2357 added the duplicate This issue or pull request already exists label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants