This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
Old JLink firmware expects some missing initialization step(s) to work correctly. #36
Comments
|
Might be because we don't register the connection #26 |
|
Thank you, this is awesome! My diffdiff --git a/examples/swdump.rs b/examples/swdump.rs
index e1031cf..697c2b1 100644
--- a/examples/swdump.rs
+++ b/examples/swdump.rs
@@ -20,7 +20,7 @@
//!
//! This example assumes that the above "bug" (or misspecification?) is present.
-use jaylink::{Interface, JayLink, SpeedConfig};
+use jaylink::{Capability, Connection, Interface, JayLink, SpeedConfig};
use log::trace;
use std::{cmp, fmt};
use structopt::StructOpt;
@@ -300,6 +300,10 @@ fn run(opts: Opts) -> Result<(), SwdError> {
println!("speed configuration: {}", speed);
probe.set_speed(speed)?;
+ if probe.capabilities().contains(Capability::Register) {
+ probe.register(Connection::default())?;
+ }
+
probe.swj_seq()?;
let dpidr = probe.raw_read(Port::Debug, 0b0000)?;
diff --git a/src/lib.rs b/src/lib.rs
index d9e8fee..b5669d8 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -93,7 +93,7 @@ pub use self::interface::{Interface, InterfaceIter, Interfaces};
use self::bits::IteratorExt as _;
use self::error::ResultExt as _;
use bitflags::bitflags;
-use byteorder::{LittleEndian, ReadBytesExt};
+use byteorder::{BigEndian, LittleEndian, ReadBytesExt, WriteBytesExt};
use io::Cursor;
use log::{debug, trace, warn};
use std::cell::{Cell, RefCell, RefMut};
@@ -162,6 +162,15 @@ enum Command {
ReadConfig = 0xF2,
WriteConfig = 0xF3,
+
+ Register = 0x09,
+}
+
+#[repr(u8)]
+#[allow(dead_code)]
+enum RegisterCommand {
+ Register = 0x64,
+ Unregister = 0x65,
}
#[repr(u8)]
@@ -208,6 +217,15 @@ impl SwoStatus {
}
}
+#[derive(Default, Debug)]
+pub struct Connection {
+ handle: u16,
+ pid: u32,
+ hid: Option<std::net::Ipv4Addr>,
+ iid: u8,
+ cid: u8,
+}
+
/// A handle to a J-Link USB device.
///
/// This is the main interface type of this library. There are multiple ways of obtaining an
@@ -628,7 +646,7 @@ impl JayLink {
///
/// This requires the probe to support [`Capability::SpeedInfo`].
pub fn read_speeds(&self) -> Result<SpeedInfo> {
- self.require_capability(Capability::SpeedInfo)?;
+ // self.require_capability(Capability::SpeedInfo)?;
self.write_cmd(&[Command::GetSpeeds as u8])?;
@@ -882,6 +900,30 @@ impl JayLink {
Ok(())
}
+ /// Registers a connection on the device.
+ ///
+ /// This requires the probe to support [`Capability::Register`].
+ ///
+ /// **Note**: This may be **required** on some devices for SWD to work at all.
+ ///
+ /// [`REGISTER`]: Capabilities::REGISTER
+ pub fn register(&self, conn: Connection) -> Result<()> {
+ self.require_capability(Capability::Register)?;
+ let mut buf = Vec::with_capacity(14);
+ buf.push(Command::Register as u8);
+ buf.push(RegisterCommand::Register as u8);
+ buf.write_u32::<LittleEndian>(conn.pid).unwrap();
+ buf.write_u32::<BigEndian>(conn.hid.unwrap_or(std::net::Ipv4Addr::LOCALHOST).into())
+ .unwrap();
+ buf.push(conn.iid);
+ buf.push(conn.cid);
+ buf.write_u16::<LittleEndian>(conn.handle).unwrap();
+ self.write_cmd(&buf)?;
+ let mut buf = [0; 76];
+ self.read(&mut buf)?;
+ Ok(())
+ }
+
/// Performs a JTAG I/O operation.
///
/// This will shift out data on `TMS` (pin 7) and `TDI` (pin 5), while reading data shifted
Should I close this issue now or it's better to wait until #26 is prettified and merged? |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There's a second issue that I discovered yesterday with the same old JLink-OB clone probes.
Although probe is detected correctly after connection, it fails to work and reports the lack of response from target:
Then I start and terminate (hit Ctrl+C) the official proprietary JLink tool (I want to get rid of this piece of non-free software, that's why I'm trying to learn how to use your library), it shows that both probe and target are OK:
And then I run
swdumpagain and... it works too:It works until I disconnect and connect my probe again, then I have to run JLinkGDBServer again. I know this report is incomplete without traces / USB communication dumps but probably someone saw this behavior too and already know the answer.
The text was updated successfully, but these errors were encountered: