Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : Add FakeAppUpdateManager. #52

Open
kishanhitk opened this issue Nov 18, 2020 · 3 comments
Open

Feature request : Add FakeAppUpdateManager. #52

kishanhitk opened this issue Nov 18, 2020 · 3 comments

Comments

@kishanhitk
Copy link

kishanhitk commented Nov 18, 2020

First of all, thank you very much @jonasbark and the community for this amazing package. 🙇
I have one feature request. Currently, to test in_app_update implementation, we have to upload the app to Internal Sharing in Play Store, therefore it is not possible to test it in real-time while coding. So, it becomes a little bit difficult for novice developers like me.
Google has released FakeAppUpdateManager for Android to test InAppUpdate locally while coding. So, is it possible to add this feature to this package also?
Until then can you please suggest me the preferred way of testing inAppUpdate implementation in my app?

Thanks
@kishanhitk

@gabrieleolmi
Copy link

essential feature!!

@jonasbark
Copy link
Owner

I will have a think about this. You can only really properly test it by using the internal sharing method in the Play Store, which is also mentioned in the official docs.

@NamanShergill
Copy link

NamanShergill commented Nov 23, 2023

I will have a think about this. You can only really properly test it by using the internal sharing method in the Play Store, which is also mentioned in the official docs.

Yeah, but if Google deemed it necessary to add the FakeAppUpdateManager, I think it only makes sense the plugin implementing the API provides it too.

This will also help with unit testing massively. Currently, trying to test this code requires the developer to make a lot of assumptions of what the class might return to mock the responses. Which, as you can see, can be wrong or change with time, thus breaking the tests without the developer potentially realising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants