Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clojure.tools.tools compatibility #446

Open
devurandom opened this issue Aug 8, 2023 · 1 comment
Open

clojure.tools.tools compatibility #446

devurandom opened this issue Aug 8, 2023 · 1 comment

Comments

@devurandom
Copy link

devurandom commented Aug 8, 2023

It would be nice if I could install eastwood using https://github.com/clojure/tools.tools (clojure.tools.tools):

❯ clojure -Ttools install-latest :lib com.github.jonase/eastwood :as eastwood
Cloning: https://github.com/jonase/eastwood.git
Checking out: https://github.com/jonase/eastwood.git at 441e3781293bcca13ccd087c099ed2f2ff40ce5b
eastwood: Installed com.github.jonase/eastwood v1.4.0 {:git/tag "v1.4.0", :git/sha "441e378"}
❯ clj -Teastwood
No function found on command line or in :exec-fn
❯ clj -Teastwood eastwood.lint/-main
== Eastwood 1.4.0 Clojure 1.11.1 JVM 17.0.7 ==
The following file(s) contain ns forms with namespaces that do not correspond
with their file names:
Directory: [REDACTED]
    File                   : test/[REDACTED]_test.clj
    has namespace          : [REDACTED]-test
    should have namespace  : test.[REDACTED]-test
    or should be in file(s): [REDACTED]_test.clj
                             [REDACTED]_test.cljc

cf. https://clojure.org/reference/deps_and_cli#_best_practices_for_tool_authors

@vemv
Copy link
Collaborator

vemv commented Aug 8, 2023

Sure thing, will look into it. We already have a tools.tools integration in a 'friend' project like https://github.com/rm-hull/nvd-clojure .

I'd have to check whether this approach affects our 'source paths inference' feature.

Cheers - V

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants