Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable notification #915

Open
srwareham opened this issue May 4, 2020 · 3 comments
Open

Configurable notification #915

srwareham opened this issue May 4, 2020 · 3 comments

Comments

@srwareham
Copy link

Thanks for the great app! It would be very helpful if the info in the notification shade could be customizable. Regardless of unit settings, it currently only displays distance in meters and pace in meters.

Although seemingly minor, I think this use case will increase in relevance as wireless headphones become even more common. When I go for a run, I can tap a button on my headphones that reads out my current notifications. For RunnerUp, this could helpfully read current my distance and speed, without needing to reach an interval checkpoint. This also would let me re-query info if I couldn't quite hear what was said during an interval callout.

I assume this is part of the bigger picture mentioned in #865, but raise the notification-specific component nonetheless.

Thanks!

@gerhardol
Copy link
Collaborator

Non metric support is certainly not great. ( I have aborted some adjustments when I did not see how to present miles/feet and decimals in a good way...)
Presentation should follow speed/pace and metric/imperial at least.
I have seen a related request to customize the notification, for use in smartwatches.

Most features are implemented by someone that finds them useful for themselves....

@srwareham
Copy link
Author

I looked through the code a bit ago and it didn't look too difficult to simply adjust the exact same style to the metric/imperial preferences. Do you have any thoughts on what a generalized solution beyond that might look like? I won't have time to get to this for a good while, but would like to put at least a simple PR together at some point.

@gerhardol
Copy link
Collaborator

metric/imperial should be automatic, it just have to be handled everywhere
It would be great if you would look into that
See for instance #624

Configuration of the notification is a separate feature
Maybe the audio cues profiles could be used for the notifications too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants