Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite template method errors #86

Open
arielfox opened this issue Aug 9, 2016 · 2 comments
Open

Composite template method errors #86

arielfox opened this issue Aug 9, 2016 · 2 comments

Comments

@arielfox
Copy link
Contributor

arielfox commented Aug 9, 2016

@madamkiwi an issue has surfaced after your July 14, 2016 commit

Please accept pull request #85 to fix this issue.

Now that the composite template methods ('create_envelope_from_composite_template' and 'get_composite_template') take an argument for files, there are errors if you don't pass files. The first error will occur in the 'create_file_ios' method because 'each_with_index' will be called on nil.

It's quite common to only use server templates and/or inline templates and not replace them with a different document. Therefore files should be optional.

@rogsmith
Copy link

rogsmith commented Aug 23, 2016

Are there any plans to expand create_envelope_from_composite_template to allow for defining inlineTemplates w/o specifying serverTemplateId. This is useful if you want to replace the underlying document from a template. See: http://stackoverflow.com/questions/29130490/docusign-api-create-envelopes-using-composite-templates

Issue now is that you have to specify the serverTemplateId or more precisely perhaps add the sequence number.

@tcopeland
Copy link
Collaborator

@arielfox #85 merged, thanks!

@rogsmith thanks for the link, I'll have to read that a few more times to grok it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants