Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get working #4

Open
ironicbrew opened this issue Dec 24, 2022 · 9 comments
Open

Unable to get working #4

ironicbrew opened this issue Dec 24, 2022 · 9 comments

Comments

@ironicbrew
Copy link

Put together an example repo of how I tried to get this to work. No sound is coming out of the simulator or my plugged in device. I'm likely missing something obvious but I've put 8 hours into getting this to work so far and I'm hard stuck.

@jonestristand
Copy link
Owner

Have you tried the same code on an android device to see if you get sound?

@ironicbrew
Copy link
Author

Tried it on Android too and no luck although I'm much less familiar with building for Android so much higher risk it's something I'm omitting

@jonestristand
Copy link
Owner

Sorry - to be honest it's been a year and a half since I've touched this project! Did you put a metronome.wav file in the ios assets bundle?

@ironicbrew
Copy link
Author

Ah that's likely what I'm missing! I'll give that a shot and let you know. I'll PR an update to the docs if that's it and I'll look into how to add an error handler to the module to prompt others that missed the same thing, although I have limited experince with Swift so implementing that might be a stretch for me.

@jonestristand
Copy link
Owner

jonestristand commented Dec 30, 2022 via email

@ironicbrew
Copy link
Author

ironicbrew commented Dec 31, 2022

Got it working, the missing file was the issue.

I see there's already a print to the console for this case but I missed it due to the volume of other things getting logged to the console. As its breaking if a dev omits this file I think the throw be permitted to be a bit more intrusive. Ideally a react-native LogBox prompt.

I tried to figure out how to use RCTLogError() like here but I'm afraid it's a bit outside of my Swift abilities to do so.

The best I can do for now is to add a note to the docs prompting users to add such a file to their project directory so they don't get stuck like I did.

@ironicbrew
Copy link
Author

ironicbrew commented Jan 9, 2023

Still working on this. Just need to figure out audio files in Android Studio and I'll PR an update to the docs.

@jonestristand
Copy link
Owner

Happy to accept a PR if you've got one :-)

@ironicbrew
Copy link
Author

Afraid I wasn't able to figure out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants