Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger_Tests.cls is a bit of a mess #816

Open
jongpie opened this issue Dec 11, 2024 · 0 comments
Open

Logger_Tests.cls is a bit of a mess #816

jongpie opened this issue Dec 11, 2024 · 0 comments
Labels
cleanup devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Layer: Logger Engine Items related to the core logging engine optimization tests Relates to Apex or LWC jest tests Type: Enhancement New feature or request

Comments

@jongpie
Copy link
Owner

jongpie commented Dec 11, 2024

@jongpie, how do you generate unit tests? Right now you have 2 message formats × 7 logging levels × 7 Database Results (some tests are still missing - MergeResult) - quite a lot.... Do you have a some kind of a generator (a script maybe)? I did most of the editing using cumbersome regexes (matching entire test methods with multiple capture groups), but maybe there is an easier way?
Anyway, please strongly consider refactoring the test class and eliminating repeated code in favor of parametrized methods.

Originally posted by @TrangOul in #806 (comment)

@jongpie jongpie added optimization cleanup devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Layer: Logger Engine Items related to the core logging engine tests Relates to Apex or LWC jest tests Type: Enhancement New feature or request labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup devops Items related to tooling, automation, and guidelines used for developing Nebula Logger Layer: Logger Engine Items related to the core logging engine optimization tests Relates to Apex or LWC jest tests Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant